From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v4 09/24] PM / devfreq: tegra30: Reset boosting on startup Date: Tue, 16 Jul 2019 21:13:52 +0900 Message-ID: References: <20190707223303.6755-1-digetx@gmail.com> <20190707223303.6755-10-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190707223303.6755-10-digetx@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , Thierry Reding , MyungJoo Ham , Kyungmin Park , Jonathan Hunter , Tomeu Vizoso Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Governor could be stopped while boosting is active. We have assumption > that everything is reset on governor's restart, including the boosting > value, which was missed. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index d5d04c25023b..32fe95458ee7 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -536,6 +536,9 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, > { > u32 val = 0, target_freq; > > + /* we don't want boosting on restart */ nitpick. I think that following comment is proper in my case. In my case, I think 'we' expression is not good /* Reset the boost frequency on restart */ > + dev->boost_freq = 0; > + > target_freq = clk_get_rate(tegra->emc_clock) / KHZ; > dev->avg_count = target_freq * ACTMON_SAMPLING_PERIOD; > device_writel(dev, dev->avg_count, ACTMON_DEV_INIT_AVG); > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics