Re: [PATCH V2 09/21] clk: tegra: dfll: add protection for find_vdd_map APIs

Jon Hunter
2018-12-13T12:46:11Z

On 13/12/2018 09:34, Joseph Lo wrote:
> The DFLL hardware supports both I2C and PWM based regulator. SW driver
> only touches I2C regulator when generating LUT. And shouldn't touch it
> anymore once the DFLL is enabled.

I am not sure that the last two sentences are above are relevant and
confused me a little at first. I would be tempted to drop them.

> This patch adds the protection for the APIs that only work with I2C mode
> to avoid they could be called accidentally.
>
> Signed-off-by: Joseph Lo <josephl@nvidia.com>

Furthermore, I would be tempted to squash this into patch #7. I am not
sure another patch is warranted here.

Cheers
Jon

--
nvpublic