From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBDE378C66 for ; Tue, 16 Apr 2024 07:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252620; cv=none; b=ORvC5XyXwX0+ZWfO0HBreCRnq/pwTkBvHyWVZ05w2BKL1q7VRLlmuJH2CT28LndPd1rF4QnQgcU78hXl0PB5WUsOa1FRklKAHMYHfRQqZzARHuWDkARe27JEzog/X2OgX9i0RnXMqADtF1+b1ycIixUjvOJc+J4cQDRUD5azKvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252620; c=relaxed/simple; bh=3EBKV7AoYCxlJECmklFzoEXRovNanxjXalvsVOT4m+o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iv4x+sMDO4kSiBxpWrmBX25m2Kd321mv9nIfYyCtt/0QDiy+BxWEVwk0fdLnzer6AaM8FDVbnRIiRefVkmOmcnSx8TpyAJNsx513bdnAF7pN45/Tl5ALjX5tDYyhXpDwKFRrGFkpN69u2qX6/zJ/V6nry1EkJHrs9pUEbe0xwVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SNlf7vio; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SNlf7vio" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a51a1c8d931so515769166b.0 for ; Tue, 16 Apr 2024 00:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713252616; x=1713857416; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cQoXqxQGz5UdNS/uHt9iOu3c65OCBEQl1AjepevvRYw=; b=SNlf7vioxt9kCwvhEUN8obQyhDYbHdl4mPQtUdgYuiGObRsj3s3lTmyk/rgfuO9C0b G/go3KPIiKXe8EL7p2wymeks0Ne2COByut5L6T4WRBNrmkwvDXUMfIYeCaaHBXelPe+z 6XNJdOsb275n+a2dt0ntwxe+TEOwv4IwBgUdks0IiqLlrWd85B3RoNpJazutUQIc1wxC sz1XqbKDXYN84YdAWzEWn0OrUHfuvgBavPzJU8YjCcZmbUNz/tnjrtDE94ylLfSPr6ei Po0ST2OC1kThPV2sUV4K3rGk8Lv/QKQdR9a41Wocb6oTxU35MJ+2E8qhC2dmJGK1n4IZ Rkiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713252616; x=1713857416; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQoXqxQGz5UdNS/uHt9iOu3c65OCBEQl1AjepevvRYw=; b=Y9EsGHbm+LOIG25K9VFkZj4kE1g/LV5wa2wIudMtOPsWYIRpbPY5oCdWJWxg6mGX62 9lcB1dp+iFcv5FGIoMtAME1gRFYF8DQ3tWYlBqRdbRwPJ7gfWrBr03Mh4jBKlkeC8pwR m4wMEN8DYV+cjFCHgFPU7y7LRA1QkQOUe+5uNL8ynfvJKYX81sqrbVe2FVgSyX5k5fHK DwK93CGOsrL/AqE/NyKqiGbnjfQjwRfZVWl6+3zj/pUaBSYdUv3aJS7O3KKZr8kkjxeG r4u69sSc3hl3ppce389UwRPWTXmA69N1ENFEnyB9dn7433APG0H5FpncamqiY8wkuxAM qr3w== X-Forwarded-Encrypted: i=1; AJvYcCW7IHNobvqAz4R61by0mactf3/b6YPwpIXnQSphvL3wNfVrh0vRs9e7jUz0BLGKZObUiSqIlgAahtKgmSoswXXO+4YUaXeu/suFMuA= X-Gm-Message-State: AOJu0Yx9dp46YK02vjJnhOHg+0vZ9DCB8IDm+WqwURn7nChCXIaj59YF je8nkQCLUIRC9ysh2PW1g/MUhoZoqqqVzUVf/ljUO8pLDuLXmAq3B9N/58m5pVk= X-Google-Smtp-Source: AGHT+IES0flyaPsDqcItqmrdcMlT/9HhmNC59nIBd1+qe6iKBoJLQjAdExVi7n8xHc0r8DPQuGmsnQ== X-Received: by 2002:a17:906:fd89:b0:a52:24b7:b4fc with SMTP id xa9-20020a170906fd8900b00a5224b7b4fcmr9643955ejb.72.1713252616011; Tue, 16 Apr 2024 00:30:16 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id h14-20020a1709070b0e00b00a518c69c4e3sm6421654ejl.23.2024.04.16.00.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 00:30:15 -0700 (PDT) Date: Tue, 16 Apr 2024 10:30:11 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 06/35] media: stm32-dcmipp: Remove redundant printk Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-6-477afb23728b@chromium.org> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-6-477afb23728b@chromium.org> On Mon, Apr 15, 2024 at 07:34:23PM +0000, Ricardo Ribalda wrote: > platform_get_irq() already prints an error message. > > Found by cocci: > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > index bce821eb71ce..c25027b0ca32 100644 > --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) > "Could not get reset control\n"); > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Could not get irq\n"); > + if (irq <= 0) > return irq ? irq : -ENXIO; platform_get_irq() can never return zero so this should be written as: irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; There is a comment next to platform_get_irq() which documents this. regards, dan carpenter