Re: [PATCH 4/4] memory: tegra: Add MC error logging support for Tegra264

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/09/2025 07:17, Ketan Patil wrote:
> +static irqreturn_t handle_sbs_irq(int irq, void *data)
> +{
> +	return handle_generic_irq((struct tegra_mc *)data, MSS_SBS_INTSTATUS_0);
> +}
> +
> +static irqreturn_t handle_channel_irq(int irq, void *data)
> +{
> +	return handle_generic_irq((struct tegra_mc *)data, MC_CH_INTSTATUS_0);
> +}


Patchset fails building (see LKP report), so I won't be doing full
review, but few obvious issues to spare you from one resubmit:

> +
> +const irq_handler_t tegra264_mc_irq_handlers[8] = {

static

> +	handle_mcf_irq, handle_hub_irq, handle_hub_irq,
> +	handle_hub_irq, handle_hub_irq, handle_hub_irq,
> +	handle_sbs_irq, handle_channel_irq
> +};
> +
> +const struct tegra_mc_ops tegra264_mc_ops = {
> +	.probe = tegra186_mc_probe,
> +	.remove = tegra186_mc_remove,
> +	.probe_device = tegra186_mc_probe_device,
> +	.resume = tegra186_mc_resume,
> +	.handle_irq = tegra264_mc_irq_handlers,
> +	.num_interrupts = ARRAY_SIZE(tegra264_mc_irq_handlers),
> +};
> +
>  static const struct tegra_mc_icc_ops tegra264_mc_icc_ops = {
>  	.xlate = tegra_mc_icc_xlate,
>  	.aggregate = tegra264_mc_icc_aggregate,
> @@ -290,18 +657,31 @@ static const struct tegra_mc_icc_ops tegra264_mc_icc_ops = {
>  	.set = tegra264_mc_icc_set,
>  };
>  


Best regards,
Krzysztof