public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: JC Kuo <jckuo@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] phy: tegra: Don't warn on probe deferral
Date: Fri, 13 Nov 2020 17:21:39 +0800	[thread overview]
Message-ID: <cfcfb222-2b4d-31e9-a868-b9e7a7e0cc6e@nvidia.com> (raw)
In-Reply-To: <20201111103708.152566-1-jonathanh@nvidia.com>

On 11/11/20 6:37 PM, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/phy/tegra/xusb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ad88d74c1884..2eafb813825b 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
>  	err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
>  				      padctl->supplies);
>  	if (err < 0) {
> -		dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
> +		dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
>  		goto remove;
>  	}
>  
> 
Acked-by: JC Kuo <jckuo@nvidia.com>

  reply	other threads:[~2020-11-13  9:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 10:37 [PATCH] phy: tegra: Don't warn on probe deferral Jon Hunter
2020-11-13  9:21 ` JC Kuo [this message]
2020-11-13 16:12 ` Thierry Reding
2020-11-16  7:49 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfcfb222-2b4d-31e9-a868-b9e7a7e0cc6e@nvidia.com \
    --to=jckuo@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox