From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DDA61386B2 for ; Tue, 23 Apr 2024 12:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713876236; cv=none; b=U8Ry7ON/ZZaWw4cU+bnO4uNpeWUsbBUGKMJueoMbY9mmCA5T/Ejbza2LUp5XBq144idnRW/o08JiKiHx0L3E9b1abeuUFg6mIWpuV+/aFH1aQLhrQCgnHg0YCGk6SRhGO6wQw3Oespr/I4+Xk3Gc3kWH7Xdt+8ArgzXXsHBK6Hc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713876236; c=relaxed/simple; bh=r0UmnNWiljWy3w/DWQQ7Ic6mYcT+iVhIRMPUeFTh3tM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bcvSD8eUAXgZScskmb1XsPx/NxaDynXVOXF9Cl5i6Pgzel3hFhmHC3isx+joTrUq241haNzBqP9Ih876JZswzI8355QCKdq+6pHh6wclE18kVXsyE2xJTTHc1I+NBGaR/nMEDiVm1zM2GMUZaA+sr9+czAS0ewaOc1OXAQW0XHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LsDtwhLs; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsDtwhLs" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41aa2f6ff2dso8054395e9.3 for ; Tue, 23 Apr 2024 05:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713876232; x=1714481032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+qnKAwgvBHM35XCDpuBit4GUKItb+LTK0jOfybUvb7k=; b=LsDtwhLsTNd6Xj4IasfsiBLv0XCxeO5W0KCfSdmEBX0mBZZ8Va5xBp6xIET1gjS1n0 KIuZyJU23Kpz2iG/R9a8ipbCFFT8k6crZEWKKeawXUwSMADN8d9hSjv6Kn5fuu3ozd9H u3NE13xcerUjPm0X6W03R32V3lvQAuxGzy6MkBMRgDqSAPtLzQfOKB0cx5pfJgA0koBR ZWx4qRcPVut3AZt9pvjdMdetMtCo6sQBBtvWE3yFHcYuouA8OSbf9Xc0jewmJ7gIdNLX 8BP5meLrW5GWUf6oH+etu9o9/8XxqoNu3vUFzhjYLxGzxlHGepwTDxp3AQxUZJIyhX4z h6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713876232; x=1714481032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+qnKAwgvBHM35XCDpuBit4GUKItb+LTK0jOfybUvb7k=; b=LozaFD8fEaVDKMIGSe9VBi3pdauLwTsxBK6kuPtVcF38sI81Tc/vTjsjVcIddYVk25 j9f5/USOa+39xWUAbauwOF6bPcolxGPdFOJlGdvfPZ0tD+Gr0bh4AibHvXeruSwegNPB HdNWlyP/+k3ROD4IcErNwx8UboE9Y5IrOnSQfAmnMTeUmDX1oINTmh+KydegVMgUI6gM LtbV3DKaGKN3s2Qp1nikWWJ4xuSQxqO8Z7VK83jKQflTlcnj0mUJ52471iBtptMrnKJb ktcQFAcbzQreoBewQSKVus4JSamDBRVBGmc5tCJP6qNH512Z0Bs8tnE5r7PLW8IFtKtR xg6Q== X-Forwarded-Encrypted: i=1; AJvYcCWa4BaPSFvzXRYzOGRNPbeJIHU96znVZ6o+Tq4K2sRwVGx35/4bWiQei1gm2Ub74WsYy8WPNFQtM1UGVxpBQTFYXMvc5CzMW7LWJDM= X-Gm-Message-State: AOJu0YzEZ0CCkW/QsoI6nOCAf08po2AJgqLwXarC8lBr5E49TNsB4jyE dNbPCiJ3lcrKgK2DP55rWaGkC1DszC6shaCrI/VUzAJEUUnZZV3jBfcquCdAw7I= X-Google-Smtp-Source: AGHT+IHx5NN+z23VludiFeHTrKmrJCe4gLG+r1lTx6C4j7QEMysWQLMdtEpvLnQqAlOL1NQMbBj3Zg== X-Received: by 2002:a5d:6a8d:0:b0:34b:5caf:6342 with SMTP id s13-20020a5d6a8d000000b0034b5caf6342mr2073298wru.67.1713876232556; Tue, 23 Apr 2024 05:43:52 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id r16-20020a5d6950000000b003477d26736dsm14506412wrw.94.2024.04.23.05.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 05:43:52 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 13:43:49 +0100 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/35] media: s2255: Use refcount_t instead of atomic_t for num_channels To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-11-477afb23728b@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240415-fix-cocci-v1-11-477afb23728b@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/04/2024 20:34, Ricardo Ribalda wrote: > Use an API that resembles more the actual use of num_channels. > > Found by cocci: > drivers/media/usb/s2255/s2255drv.c:2362:5-24: WARNING: atomic_dec_and_test variation before object free at line 2363. > drivers/media/usb/s2255/s2255drv.c:1557:5-24: WARNING: atomic_dec_and_test variation before object free at line 1558. Hmm, that commit log needs more detail. "Convert from atomic_t to refcount_t because refcount_t has memory ordering guarantees which atomic does not, hence the WARNING for the free after the atomic dec." Something like that. I'll leave it up to yourself to decide if this warrants a Fixes: I don't think so myself because the previous code doesn't seem to matter to the decrement and free. --- bod