Re: [PATCH 2/3] thermal/drivers/tegra: Remove get_trend function

Dmitry Osipenko
2022-06-29T20:05:43Z

On 6/16/22 23:25, Daniel Lezcano wrote:
> The get_trend function does already what the generic framework does.
>
> Remove it.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/tegra/soctherm.c | 32 --------------------------------
> 1 file changed, 32 deletions(-)
>
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index 210325f92559..825eab526619 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -633,37 +633,6 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp)
> return 0;
> }
>
> -static int tegra_thermctl_get_trend(void *data, int trip,
> - enum thermal_trend *trend)
> -{
> - struct tegra_thermctl_zone *zone = data;
> - struct thermal_zone_device *tz = zone->tz;
> - int trip_temp, temp, last_temp, ret;
> -
> - if (!tz)
> - return -EINVAL;
> -
> - ret = tz->ops->get_trip_temp(zone->tz, trip, &trip_temp);
> - if (ret)
> - return ret;
> -
> - temp = READ_ONCE(tz->temperature);
> - last_temp = READ_ONCE(tz->last_temperature);
> -
> - if (temp > trip_temp) {
> - if (temp >= last_temp)
> - *trend = THERMAL_TREND_RAISING;
> - else
> - *trend = THERMAL_TREND_STABLE;
> - } else if (temp < trip_temp) {
> - *trend = THERMAL_TREND_DROPPING;
> - } else {
> - *trend = THERMAL_TREND_STABLE;
> - }
> -
> - return 0;
> -}
> -
> static void thermal_irq_enable(struct tegra_thermctl_zone *zn)
> {
> u32 r;
> @@ -716,7 +685,6 @@ static int tegra_thermctl_set_trips(void *data, int lo, int hi)
> static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> .get_temp = tegra_thermctl_get_temp,
> .set_trip_temp = tegra_thermctl_set_trip_temp,
> - .get_trend = tegra_thermctl_get_trend,
> .set_trips = tegra_thermctl_set_trips,
> };
>

Guenter fixed the LM90 driver problem. There are other regressions in
the latest -next which complicate testing, but I can't see any problems
from the thermal side.

Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

--
Best regards,
Dmitry