From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C05D513B787; Fri, 21 Feb 2025 14:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740149114; cv=none; b=Jj94YvKAypqr+TLkgC36vCLb7ZNARTnzEtP4F+6sAgf0F90UG7/HAIA9eChl1OezO75+bqjjfGkO1erjz8cdUOwu5bfta8y6A2HYAujJMMLrYaAxmZEaaO5ONvamFbq0F4Bmn30OmZYQ7qRhv6KP+hCzBXBk41IMOGejQ03oXi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740149114; c=relaxed/simple; bh=R7JS7jIZcjDSPrwz8G0a0Y/N00Su0rg91ouIBSJPJcI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KLQ5/jmBwldG/MKPadHk1JVKpXQOCoZjm5LAVFecvMiYP4gpQIdyYe2wdYjB4BKll5Oo5EfJo3mncwSOlMSkw5cHZnAEIlZP7F9Xh2+IVUxdd9IGeGdlpl0ezb5mlYF2twT5y7v/SVxk4bEZmvlpXzV/1H0WXgRz8KuvOjcSZPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5183A106F; Fri, 21 Feb 2025 06:45:27 -0800 (PST) Received: from [192.168.2.132] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E84843F5A1; Fri, 21 Feb 2025 06:45:04 -0800 (PST) Message-ID: Date: Fri, 21 Feb 2025 15:45:03 +0100 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier for hotplug To: Jon Hunter , Juri Lelli Cc: Christian Loehle , Thierry Reding , Waiman Long , Tejun Heo , Johannes Weiner , Michal Koutny , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Phil Auld , Qais Yousef , Sebastian Andrzej Siewior , "Joel Fernandes (Google)" , Suleiman Souhlal , Aashish Sharma , Shin Kawamura , Vineeth Remanan Pillai , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "linux-tegra@vger.kernel.org" References: <151884eb-ad6d-458e-a325-92cbe5b8b33f@nvidia.com> <4c045707-6f5a-44fd-b2d1-3ad13c2b11ba@arm.com> <537f2207-b46b-4a5e-884c-d6b42f56cb02@arm.com> <1c75682e-a720-4bd0-8bcc-5443b598457f@nvidia.com> From: Dietmar Eggemann Content-Language: en-US In-Reply-To: <1c75682e-a720-4bd0-8bcc-5443b598457f@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 21/02/2025 12:56, Jon Hunter wrote: > > On 20/02/2025 15:25, Juri Lelli wrote: >> On 20/02/25 11:40, Juri Lelli wrote: >>> On 19/02/25 19:14, Dietmar Eggemann wrote: [...] > Latest branch is not building for me ... > >   CC      kernel/time/hrtimer.o > In file included from kernel/sched/build_utility.c:88: > kernel/sched/topology.c: In function ‘partition_sched_domains’: > kernel/sched/topology.c:2817:9: error: implicit declaration of function > ‘dl_rebuild_rd_accounting’ [-Werror=implicit-function-declaration] >  2817 |         dl_rebuild_rd_accounting(); >       |         ^~~~~~~~~~~~~~~~~~~~~~~~ This should fix it for now: -->8-- diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 52243dcc61ab..3484dda93a94 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -954,7 +954,9 @@ static void dl_update_tasks_root_domain(struct cpuset *cs) css_task_iter_end(&it); } -static void dl_rebuild_rd_accounting(void) +extern void dl_rebuild_rd_accounting(void); + +void dl_rebuild_rd_accounting(void) { struct cpuset *cs = NULL; struct cgroup_subsys_state *pos_css; diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 9892e6fa3e57..60c9996ccf47 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2806,6 +2806,8 @@ void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[], update_sched_domain_debugfs(); } +extern void dl_rebuild_rd_accounting(void); + /* * Call with hotplug lock held */