From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH V2] tty: serial: Add const to struct =?UTF-8?Q?uart=5Fops=20declarations?= Date: Mon, 06 Apr 2015 01:09:06 +0200 Message-ID: References: <1428169665.2775.53.camel@perches.com> <1428258294.2775.69.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428258294.2775.69.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joe Perches Cc: Greg Kroah-Hartman , Jiri Slaby , linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, Nicolas Ferre , Timur Tabi , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pat Gefre , Laxman Dewangan , "Maciej W. Rozycki" , Daniel Walker , sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Korsgaard , Sonic Zhang , Alexandre Courbot , Russell King , Michal Simek , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tobias Klauser , Stephen Warren , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Thadeu Lima de Souza Cascardo linux List-Id: linux-tegra@vger.kernel.org On 2015-04-05 20:24, Joe Perches wrote: > Still compiled only x86 and not cross-compiled or tested. Cross-compiled with multi_v7_defconfig > > drivers/tty/serial/21285.c | 2 +- > drivers/tty/serial/altera_jtaguart.c | 2 +- > drivers/tty/serial/altera_uart.c | 2 +- > drivers/tty/serial/amba-pl010.c | 2 +- > drivers/tty/serial/amba-pl011.c | 2 +- > drivers/tty/serial/apbuart.c | 2 +- > drivers/tty/serial/ar933x_uart.c | 2 +- > drivers/tty/serial/arc_uart.c | 2 +- > drivers/tty/serial/atmel_serial.c | 2 +- > drivers/tty/serial/bcm63xx_uart.c | 2 +- > drivers/tty/serial/bfin_sport_uart.c | 2 +- > drivers/tty/serial/bfin_uart.c | 2 +- > drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 +- > drivers/tty/serial/dz.c | 2 +- > drivers/tty/serial/efm32-uart.c | 2 +- > drivers/tty/serial/fsl_lpuart.c | 4 ++-- Tested that driver on actual hardware, looks fine. > drivers/tty/serial/icom.c | 2 +- > drivers/tty/serial/imx.c | 2 +- > drivers/tty/serial/ioc3_serial.c | 2 +- > drivers/tty/serial/ioc4_serial.c | 2 +- > drivers/tty/serial/ip22zilog.c | 2 +- > drivers/tty/serial/jsm/jsm_tty.c | 2 +- > drivers/tty/serial/lantiq.c | 2 +- > drivers/tty/serial/lpc32xx_hs.c | 2 +- > drivers/tty/serial/m32r_sio.c | 2 +- > drivers/tty/serial/max3100.c | 2 +- > drivers/tty/serial/men_z135_uart.c | 2 +- > drivers/tty/serial/meson_uart.c | 2 +- > drivers/tty/serial/mpc52xx_uart.c | 2 +- > drivers/tty/serial/mpsc.c | 2 +- > drivers/tty/serial/msm_serial.c | 2 +- > drivers/tty/serial/mux.c | 2 +- > drivers/tty/serial/mxs-auart.c | 2 +- > drivers/tty/serial/netx-serial.c | 2 +- > drivers/tty/serial/nwpserial.c | 2 +- > drivers/tty/serial/omap-serial.c | 2 +- > drivers/tty/serial/pch_uart.c | 2 +- > drivers/tty/serial/pmac_zilog.c | 2 +- > drivers/tty/serial/pnx8xxx_uart.c | 2 +- > drivers/tty/serial/pxa.c | 2 +- > drivers/tty/serial/sa1100.c | 2 +- > drivers/tty/serial/samsung.c | 2 +- This driver seems to alter the startup function on initialization: CC drivers/video/of_display_timing.o ../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port': ../drivers/tty/serial/samsung.c:1702:3: error: assignment of member 'startup' in read-only object s3c24xx_serial_ops.startup = s3c64xx_serial_startup; ^ > drivers/tty/serial/serial-tegra.c | 2 +- > drivers/tty/serial/serial_ks8695.c | 2 +- > drivers/tty/serial/serial_txx9.c | 2 +- > drivers/tty/serial/sh-sci.c | 2 +- > drivers/tty/serial/sirfsoc_uart.c | 2 +- > drivers/tty/serial/sn_console.c | 2 +- > drivers/tty/serial/sprd_serial.c | 2 +- > drivers/tty/serial/st-asc.c | 2 +- > drivers/tty/serial/sunhv.c | 2 +- > drivers/tty/serial/sunsab.c | 2 +- > drivers/tty/serial/sunsu.c | 2 +- > drivers/tty/serial/sunzilog.c | 2 +- > drivers/tty/serial/timbuart.c | 2 +- > drivers/tty/serial/uartlite.c | 2 +- > drivers/tty/serial/ucc_uart.c | 2 +- > drivers/tty/serial/vr41xx_siu.c | 2 +- > drivers/tty/serial/vt8500_serial.c | 2 +- > drivers/tty/serial/xilinx_uartps.c | 2 +- > drivers/tty/serial/zs.c | 2 +- > 61 files changed, 62 insertions(+), 62 deletions(-) That is the only thing which popped up with multi_v7_defconfig. -- Stefan