From: Ashish Mhetre <amhetre@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <linux-tegra@vger.kernel.org>,
<krzysztof.kozlowski@canonical.com>,
<linux-kernel@vger.kernel.org>
Cc: <Snikam@nvidia.com>, <vdumpa@nvidia.com>
Subject: Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward
Date: Fri, 21 Jan 2022 11:21:57 +0530 [thread overview]
Message-ID: <d679cd46-d74b-46e2-bfbe-d54b56e39a7b@nvidia.com> (raw)
In-Reply-To: <cd7a212e-71ff-90a6-d3dc-1391567fc113@gmail.com>
On 1/20/2022 6:29 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.01.2022 12:02, Ashish Mhetre пишет:
>> @@ -521,23 +535,64 @@ static irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
>>
>> for_each_set_bit(bit, &status, 32) {
>> const char *error = tegra_mc_status_names[bit] ?: "unknown";
>> + u32 status_reg = MC_ERR_STATUS, addr_reg = MC_ERR_ADR;
>
> No need to initialize these variables, since they are always initialized
> by the further code.
>
> Please write it like this:
>
> u32 addr_hi_reg = 0, status_reg, addr_reg;
Okay, I will remove initialization.
next prev parent reply other threads:[~2022-01-21 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 9:02 [Patch V2] memory: tegra: Add MC error logging on tegra186 onward Ashish Mhetre
2022-01-20 12:53 ` Dmitry Osipenko
2022-01-21 5:50 ` Ashish Mhetre
2022-01-20 12:59 ` Dmitry Osipenko
2022-01-21 5:51 ` Ashish Mhetre [this message]
2022-01-20 13:06 ` Dmitry Osipenko
2022-01-21 5:52 ` Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d679cd46-d74b-46e2-bfbe-d54b56e39a7b@nvidia.com \
--to=amhetre@nvidia.com \
--cc=Snikam@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox