From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jimmy Zhang Subject: RE: [tegrarcm PATCH v2] Add support for production devices secured with PKC Date: Tue, 1 Mar 2016 18:26:41 +0000 Message-ID: References: <1456768181-12983-1-git-send-email-alban.bedel@avionic-design.de> <20160301121240.596c664c@avionic-0020> <56D5D245.3000204@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <56D5D245.3000204-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren , Alban Bedel Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org > -----Original Message----- > From: Stephen Warren [mailto:swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org] > Sent: Tuesday, March 01, 2016 9:33 AM > To: Alban Bedel; Jimmy Zhang > Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Subject: Re: [tegrarcm PATCH v2] Add support for production devices > secured with PKC > > On 03/01/2016 04:12 AM, Alban Bedel wrote: > > On Mon, 29 Feb 2016 23:03:01 +0000 > > Jimmy Zhang wrote: > > > >> Alban, > >> > >> First of all, I believe the code your added here should and will work. > >> However, it is probably purely coincident that I was adding similar > >> functions as requested by Avionic Design (AD) in the last a few weeks. > >> I think we could merge both approaches and result in one best > >> solution. > > > > Up to yesterday what I did was only based on guess work, it was enough > > to use RCM, but loading the bootloader failed. Now we finally got > > access to (part of) the miniloader source and I was able to pin point > > the missing piece to start the bootloader. The miniloader need the > > bootloader signature before the bootloader binary when in PKC mode. > > I added that and I was finally able to bootstrap my fused board. > > > >> The main differences between your and mine are: > >> 1. When to sign. > >> My solution is to separate signing and flashing. Ie, signing can > >> be done at a secure server and flashing at non-secure factory. During > >> flashing, only signed RCM messages and bootloader are needed. No pkc > >> private key file is required to be present at factory. This private > >> key management feature is also requested by AD. Your solution > >> requires the rsa key file being present when downloading flasher. > > > > Yes, this is currently not suited for production. > > Given that, I think I'll ignore this patch series for now. It's typical to mark such > patches "RFC" in the email subject to indicate that they shouldn't be applied. > Hopefully you and Jimmy can work together to combine your work and post > a production-ready patch set? I have sent my patches and total solution to Alban last night. Seems it was missed. I will send out again.