Re: [PATCH 04/12] PCI: tegra: Advertise AER capability

Vidya Sagar
2017-10-29T09:39:54Z

On Saturday 28 October 2017 12:59 AM, Manikanta Maddireddy wrote:
> Default root port settings hide AER capability. This patch enables the
> advertisement of AER capability by root port.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/pci/host/pci-tegra.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index 15df60e13a14..c0cd88103e9e 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -187,6 +187,9 @@
> #define RP_VEND_XP 0x00000f00
> #define RP_VEND_XP_DL_UP (1 << 30)
>
> +#define RP_VEND_CTL1 0xf48
> +#define RP_VEND_CTL1_ERPT (1 << 13)
BIT macro is preferred here.
> +
> #define RP_VEND_CTL2 0x00000fa8
> #define RP_VEND_CTL2_PCA_ENABLE (1 << 7)
>
> @@ -2055,6 +2058,16 @@ static void tegra_pcie_apply_pad_settings(struct tegra_pcie *pcie)
> pads_writel(pcie, soc->pads_refclk_cfg1, PADS_REFCLK_CFG1);
> }
>
> +static void tegra_pcie_enable_rp_features(struct tegra_pcie_port *port)
> +{
> + unsigned long value;
> +
> + /* Enable AER capability */
> + value = readl(port->base + RP_VEND_CTL1);
> + value |= RP_VEND_CTL1_ERPT;
> + writel(value, port->base + RP_VEND_CTL1);
> +}
> +
> /*
> * FIXME: If there are no PCIe cards attached, then calling this function
> * can result in the increase of the bootup time as there are big timeout
> @@ -2119,6 +2132,7 @@ static void tegra_pcie_enable_ports(struct tegra_pcie *pcie)
> port->index, port->lanes);
>
> tegra_pcie_port_enable(port);
> + tegra_pcie_enable_rp_features(port);
> }
>
> /* take the PCIe interface module out of reset */