Re: [RFC PATCH v2 1/6] ASoC: dt-bindings: Convert rt5659 bindings to YAML schema

Krzysztof Kozlowski
2022-03-28T07:02:49Z

On 28/03/2022 08:14, Sameer Pujar wrote:
> Convert rt5659.txt DT binding to YAML schema. This binding is applicable
> to rt5658 and rt5659 audio CODECs.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Cc: Oder Chiou <oder_chiou@realtek.com>
> ---
> .../devicetree/bindings/sound/realtek,rt5659.yaml | 112 +++++++++++++++++++++
> Documentation/devicetree/bindings/sound/rt5659.txt | 89 ----------------
> 2 files changed, 112 insertions(+), 89 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/rt5659.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
> new file mode 100644
> index 0000000..3bd9b6f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml
> @@ -0,0 +1,112 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,rt5659.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RT5658 and RT5659 audio CODECs
> +
> +description: This device supports I2C only.
> +
> +maintainers:
> + - Oder Chiou <oder_chiou@realtek.com>
> +
> +allOf:
> + - $ref: name-prefix.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - realtek,rt5658
> + - realtek,rt5659
> +
> + reg:
> + description: The I2C address of the device

Skip the description, it's obvious.

> + maxItems: 1
> +
> + interrupts:
> + description: The CODEC's interrupt output

Ditto.

> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Master clock (MCLK) to the CODEC
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + realtek,in1-differential:
> + description: MIC1 input is differntial and not single-ended.

typo (differential)

> + type: boolean
> +
> + realtek,in3-differential:
> + description: MIC3 input is differntial and not single-ended.
> + type: boolean
> +
> + realtek,in4-differential:
> + description: MIC3 input is differntial and not single-ended.

MIC4?

> + type: boolean
> +
> + realtek,dmic1-data-pin:
> + description: DMIC1 data pin usage
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # dmic1 is not used
> + - 1 # using IN2N pin as dmic1 data pin
> + - 2 # using GPIO5 pin as dmic1 data pin
> + - 3 # using GPIO9 pin as dmic1 data pin
> + - 4 # using GPIO11 pin as dmic1 data pin
> +
> + realtek,dmic2-data-pin:
> + description: DMIC2 data pin usage
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # dmic2 is not used
> + - 1 # using IN2P pin as dmic2 data pin
> + - 2 # using GPIO6 pin as dmic2 data pin
> + - 3 # using GPIO10 pin as dmic2 data pin
> + - 4 # using GPIO12 pin as dmic2 data pin
> +
> + realtek,jd-src:
> + description: Jack detect source
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # No JD is used
> + - 1 # using JD3 as JD source
> + - 2 # JD source for Intel HDA header
> +
> + realtek,ldo1-en-gpios:
> + description: The GPIO that controls the CODEC's LDO1_EN pin.

maxItems

> +
> + realtek,reset-gpios:
> + description: The GPIO that controls the CODEC's RESET pin.

maxItems

What about the ports node?

Best regards,
Krzysztof