From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E26EB64D7 for ; Wed, 21 Jun 2023 18:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbjFUSGc (ORCPT ); Wed, 21 Jun 2023 14:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbjFUSGb (ORCPT ); Wed, 21 Jun 2023 14:06:31 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B385E41; Wed, 21 Jun 2023 11:06:29 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-54f75f85a17so3342508a12.0; Wed, 21 Jun 2023 11:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687370789; x=1689962789; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=Az2bQMNiNgvxrY9glBfDppHJtPk+FnOiirU3h5SFUmI=; b=GBwqsylX82eyyI6jaGm8GsagHkfo1ldmyJdiuXnqzkqc4ixPDGmBndPn+m5n78gbEX grQ43KpF9obw2HM0F+0Da2EX7FG1TM+0L9uhuv2VxtTTh4Shtd4OnCRuABGudvVq5VNz iQaWR9MzmTbR4azKVOEb4dzjdFL4zISHzQ8Xai7eC0gVhiFfJ7tVYQ5E9AAcbFn9q22k 8Ov5oteaP4Ey9KJbsK4m7VfpYJ2OGGic9pmnWe9y4g9aXPHbx1psYi9x54FtmJyaOHTJ If9gncUlG0NfkZN0/Ht0Eesf6ACs38AOXcM3/k8dkmspSHj3mSTLO0ygf69hIR5HeY/c 7xjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687370789; x=1689962789; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Az2bQMNiNgvxrY9glBfDppHJtPk+FnOiirU3h5SFUmI=; b=fqrko/XIq5Sojnp7wUTCpxw6RGyV40qUZ5O/rSE5LDXTmtHrtY300NkjNAhZtkprzI Rhvs8wT0I3YCTNaThrddO8AnEyB/rMYIMOq5sI2tfxTZZFTZGTiJ1AnXaDssl36sEtKZ IFBr36fZUQ01gM2rOKj4kvY0IBbAQFMlenAgBPkhVgG4UymXmL/kqn6LGA7M5s9z42Gt QcRphIdKuL0m8O5Ud9VohtLpvCfbNJVTNJw5aHAFXnUHSB2rOplNGgtZnrvMbXhpgTZi 0b8nzh7uBqzW9uIEt9NtdgF1kTkuGiu9Ed5yDB3L/ApCY2bCbdil/zoNS9kjdEqpF52K KeIw== X-Gm-Message-State: AC+VfDweWjG/eRHWISC+sLexIOMrpBoMKsCPg6/LxcfrsE+Y6kQM11t8 7ptEcEOlS2NtzmX9LfS+Az0= X-Google-Smtp-Source: ACHHUZ4rfAeGFSguwikDDJBGuQb8NhqAfqZhPlTkMSahmVCwaEWtuwULvNAqRQTIu3CqkjuDrOxkMw== X-Received: by 2002:a17:90a:bb85:b0:24d:fbaf:e0b1 with SMTP id v5-20020a17090abb8500b0024dfbafe0b1mr9657024pjr.19.1687370788961; Wed, 21 Jun 2023 11:06:28 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id gq17-20020a17090b105100b00260e7c2cedesm1762390pjb.57.2023.06.21.11.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 11:06:27 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 21 Jun 2023 11:06:26 -0700 From: Guenter Roeck To: Krzysztof Kozlowski Cc: Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table Message-ID: References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski What happened wit hthis patch ? I still don't see it applied. FWIW: Reviewed-and-tested-by: Guenter Roeck Thanks, Guenter > --- > drivers/media/cec/i2c/ch7322.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c > index 34fad7123704..3c6e6496a001 100644 > --- a/drivers/media/cec/i2c/ch7322.c > +++ b/drivers/media/cec/i2c/ch7322.c > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match); > static struct i2c_driver ch7322_i2c_driver = { > .driver = { > .name = "ch7322", > - .of_match_table = of_match_ptr(ch7322_of_match), > + .of_match_table = ch7322_of_match, > }, > .probe_new = ch7322_probe, > .remove = ch7322_remove, > -- > 2.34.1 >