From: Tang Bin <tangbin@cmss.chinamobile.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@linuxfoundation.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, linux-usb@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci-tegra: Fix error handling integra_ehci_probe()
Date: Tue, 27 Oct 2020 09:12:39 +0800 [thread overview]
Message-ID: <dc475369-2e24-549e-9c19-daf3a8ac80ac@cmss.chinamobile.com> (raw)
In-Reply-To: <20201026150538.GA1192191@rowland.harvard.edu>
在 2020/10/26 23:05, Alan Stern 写道:
> On Mon, Oct 26, 2020 at 05:06:57PM +0800, Tang Bin wrote:
>> If the function platform_get_irq() failed, the negative value
>> returned will not be detected here. So fix error handling in
>> tegra_ehci_probe().
>>
>> Fixes: 79ad3b5add4a ("usb: host: Add EHCI driver for NVIDIA Tegra SoCs")
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>> ---
>> drivers/usb/host/ehci-tegra.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
>> index 75a075daf..7b0efaf15 100644
>> --- a/drivers/usb/host/ehci-tegra.c
>> +++ b/drivers/usb/host/ehci-tegra.c
>> @@ -479,9 +479,9 @@ static int tegra_ehci_probe(struct platform_device *pdev)
>> u_phy->otg->host = hcd_to_bus(hcd);
>>
>> irq = platform_get_irq(pdev, 0);
>> - if (!irq) {
>> - err = -ENODEV;
>> - goto cleanup_phy;
>> + if (irq < 0) {
>> + err = irq;
>> + goto cleanup_phy;
>> }
>>
>> otg_set_host(u_phy->otg, &hcd->self);
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> The "if (!irq)" statement occurs at least one other driver in this
> directory. Would you like to submit a patch for ehci-xilinx-of.c as
> well?
OK, I will check this file out. Thanks!
Tang Bin
next prev parent reply other threads:[~2020-10-27 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 9:06 [PATCH] usb: host: ehci-tegra: Fix error handling in tegra_ehci_probe() Tang Bin
2020-10-26 15:05 ` Alan Stern
2020-10-27 1:12 ` Tang Bin [this message]
2020-10-27 13:03 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc475369-2e24-549e-9c19-daf3a8ac80ac@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox