From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Sasha Levin <sashal@kernel.org>
Cc: <adrian.hunter@intel.com>, <ulf.hansson@linaro.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<robh+dt@kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210
Date: Fri, 28 Aug 2020 16:23:48 -0700 [thread overview]
Message-ID: <dc6bfd08-baaf-e1ad-6b3f-77ff82d110bb@nvidia.com> (raw)
In-Reply-To: <20200828231536.GU8670@sasha-vm>
On 8/28/20 4:15 PM, Sasha Levin wrote:
> On Fri, Aug 28, 2020 at 03:25:11PM -0700, Sowjanya Komatineni wrote:
>> commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support")
>
> What does this line above represent?
>
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set incorrectly in above commit
when Tegra210 support was added.
>> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set for Tegra210 from the
>> beginning of Tegra210 support in the driver.
>>
>> Tegra210 SDMMC hardware by default uses timeout clock (TMCLK)
>> instead of SDCLK and this quirk should not be set.
>>
>> So, this patch remove this quirk for Tegra210.
>>
>> Fixes: b5a84ecf025a ("mmc: tegra: Add Tegra210 support")
>> Cc: stable <stable@vger.kernel.org> # 4.19
>> Tested-by: Jon Hunter <jonathanh@nvidia.com>
>> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>
next prev parent reply other threads:[~2020-08-28 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 22:25 [PATCH 4.19 0/7] Fix timeout clock used by hardware data timeout Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210 Sowjanya Komatineni
2020-08-28 23:15 ` Sasha Levin
2020-08-28 23:23 ` Sowjanya Komatineni [this message]
2020-09-01 13:55 ` Greg KH
2020-08-28 22:25 ` [PATCH 4.19 2/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186 Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 3/7] dt-bindings: mmc: tegra: Add tmclk for Tegra210 and Tegra186 Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 4/7] arm64: tegra: Add missing timeout clock to Tegra210 SDMMC Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 5/7] arm64: tegra: Add missing timeout clock to Tegra186 SDMMC nodes Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 6/7] arm64: tegra: Add missing timeout clock to Tegra194 " Sowjanya Komatineni
2020-08-28 22:25 ` [PATCH 4.19 7/7] sdhci: tegra: Add missing TMCLK for data timeout Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc6bfd08-baaf-e1ad-6b3f-77ff82d110bb@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).