From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: arm@kernel.org, soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 19/40] arm64: dts: tegra: align gpio-key node names with dtschema
Date: Fri, 24 Jun 2022 18:09:44 +0200 [thread overview]
Message-ID: <dcd4be85-21ab-beb9-e6dc-bd7f570459fd@linaro.org> (raw)
In-Reply-To: <YrXhb5izGPNXEmMK@orome>
On 24/06/2022 18:08, Thierry Reding wrote:
> On Wed, Jun 15, 2022 at 05:53:12PM -0700, Krzysztof Kozlowski wrote:
> [...]
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> index f16acb4cabaa..62d58221ad3c 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> @@ -1030,7 +1030,7 @@ clk32k_in: clock-32k {
>> gpio-keys {
>> compatible = "gpio-keys";
>>
>> - lid {
>> + switch-lid {
>> label = "Lid";
>> gpios = <&gpio TEGRA_GPIO(R, 4) GPIO_ACTIVE_LOW>;
>> linux,input-type = <5>;
>> @@ -1039,7 +1039,7 @@ lid {
>> wakeup-source;
>> };
>>
>> - power {
>> + switch-power {
>
> This one is actually a key.
>
> [...]
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> index a263d51882ee..8494c7b2961b 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> [...]
>> @@ -1772,7 +1772,7 @@ lid {
>> wakeup-source;
>> };
>>
>> - tablet_mode {
>> + key-tablet-mode {
>> label = "Tablet Mode";
>> gpios = <&gpio TEGRA_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
>> linux,input-type = <EV_SW>;
>
> And this one more like a switch since it's triggered by a magnet, as far
> as I understand.
>
> No need to resend, I can fix these up when I apply. Just let me know if
> you have any objections to me making those changes.
Sounds good, thanks for catching these.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-24 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 0:52 [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 19/40] arm64: dts: tegra: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-24 16:08 ` Thierry Reding
2022-06-24 16:09 ` Krzysztof Kozlowski [this message]
2022-06-27 8:45 ` Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 20/40] ARM: " Krzysztof Kozlowski
2022-06-18 3:02 ` (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Nishanth Menon
2022-06-22 19:47 ` Heiko Stuebner
2022-07-03 3:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd4be85-21ab-beb9-e6dc-bd7f570459fd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox