From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Mikko Perttunen" <mperttunen@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>
Cc: linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Yi-Wei Wang <yiweiw@nvidia.com>
Subject: Re: [PATCH 5/5] pwm: tegra: Add support for Tegra264
Date: Mon, 23 Mar 2026 08:24:27 +0100 [thread overview]
Message-ID: <de5e6159-ae89-4b8f-948a-678cea9211fa@kernel.org> (raw)
In-Reply-To: <20260323-t264-pwm-v1-5-4c4ff743050f@nvidia.com>
On 23/03/2026 03:36, Mikko Perttunen wrote:
> +
> static const struct of_device_id tegra_pwm_of_match[] = {
> { .compatible = "nvidia,tegra20-pwm", .data = &tegra20_pwm_soc },
> { .compatible = "nvidia,tegra186-pwm", .data = &tegra186_pwm_soc },
> { .compatible = "nvidia,tegra194-pwm", .data = &tegra186_pwm_soc },
> + { .compatible = "nvidia,tegra264-pwm", .data = &tegra264_pwm_soc },
Undocumented ABI.
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-23 7:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 2:36 [PATCH 0/5] Tegra264 PWM support Mikko Perttunen
2026-03-23 2:36 ` [PATCH 1/5] pwm: tegra: Avoid hard-coded max clock frequency Mikko Perttunen
2026-03-24 16:45 ` Uwe Kleine-König
2026-03-25 0:34 ` Mikko Perttunen
2026-03-25 6:12 ` Uwe Kleine-König
2026-03-25 6:42 ` Viresh Kumar
2026-03-23 2:36 ` [PATCH 2/5] pwm: tegra: Modify read/write accessors for multi-register channel Mikko Perttunen
2026-03-23 2:36 ` [PATCH 3/5] pwm: tegra: Parametrize enable register offset Mikko Perttunen
2026-03-23 2:36 ` [PATCH 4/5] pwm: tegra: Parametrize duty and scale field widths Mikko Perttunen
2026-03-23 2:36 ` [PATCH 5/5] pwm: tegra: Add support for Tegra264 Mikko Perttunen
2026-03-23 7:24 ` Krzysztof Kozlowski [this message]
2026-03-24 4:46 ` Mikko Perttunen
2026-03-23 7:24 ` [PATCH 0/5] Tegra264 PWM support Krzysztof Kozlowski
2026-03-24 4:46 ` Mikko Perttunen
2026-03-24 16:45 ` Uwe Kleine-König
2026-03-24 23:55 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5e6159-ae89-4b8f-948a-678cea9211fa@kernel.org \
--to=krzk@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=ukleinek@kernel.org \
--cc=yiweiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox