From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B903C09FF for ; Thu, 15 Oct 2026 14:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792075558; cv=none; b=kPYtnvfNvfZ56I5vVZ6GDAcbd8ricPHdx0SnhOYXBmVNNZ8kDubv94cMBXQm059/9CeFvDj/ibrd4T3V6iKNGwjT2CJNy3f+7GZ//ak4X68wgUpE4TUTA9/R3IK93OgM/gudB+R7W3nuq0YNDbrw44FNDXstpmHtXMBRW6qHbIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792075558; c=relaxed/simple; bh=J1DmfvQ3bSlmu/fY22Cf1h8mrdFixKrrTxBkC8vPwI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HD0/xGXwQWDmMvgBXvHQbWStpoWVLTYmMIqOpSSih0WgAF0qSTcNaMyFeCthhqKVqK7NlH/C0GyT6cIAO2mxjDcyyFGRZQwwX2Xfl/OGmgPFrEIbvM4UgzTrrgIWGbxT1zA6TOynNs3pVsx/MDsARMaGIPSINa2h+JE2QA0plhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s8W2ipto; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s8W2ipto" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-8ab395abf79so43244827b3.0 for ; Thu, 15 Oct 2026 07:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792075556; x=1792680356; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nY8bEQTDRiBiqLeVmhJUy+oN+INRLBn8jSuVjWbtsUo=; b=s8W2ipto/aWRWpFxAIqUY6y0MSrQssOEs/bVyNaujmvpukZ/Xm4257+Nmh/TpUJ4d8 bzP6n0CIHixnzcTPP6PZDBtH3cUB3d6LgC9tWAqFS68aJZke8a9PvvsXIz3cxv7S6/Et VurJ6vRUZ3/KlayrHsom4nmFQD9m0XzhqR43r/qSRXdUZYJyGfe5pJsNt5x+xbzrL3DK JF0DO2xO8aMDppAPR5TvXMENm11uv/XfxohFEmZRjovHeidH1Ngi5IoMlCgf2WXHqu+V dLCC6eUhOwTsxaB7RJ235swfCQlCZd8pnoIeh3glU1RHAI/JzgSw0OGUyFUXHhYD72kE tIQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792075556; x=1792680356; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nY8bEQTDRiBiqLeVmhJUy+oN+INRLBn8jSuVjWbtsUo=; b=IsfZLLz+knlhS3lej/+5qfnTm1UlENhpTRPs6BawbGG/fIwD3snZjyAhmSC4MXOVvM lcgcUM2etFURzILDODRBGMn1x0aj1aN8CVCy3vYXyAQOU450CyQbzGwI+lTQCQU6B4Bd PeGviz+C+W9M+5cOEqWwkpZYqExMkhHE/xm7HtFMyXA1Fx1/+4q34+5KnArZKEvJK8vc +KApjJfp78WtqyEbXa5Jd1je3eZ7mBRiZVsfIEgv4W2AxdCRxWmAKeDRuuDAipnUbvhx TZLdHzB0XWET1XkN+TKvXyTJfZARVHkpbg55KAbbrmAnw2SPRe/fVtSd26uCVZTb5q8B uchw== X-Forwarded-Encrypted: i=1; AKwUvByUbWzrooGGreGn6HJW1+MbliLImhYu92BvfiaruppVzI4DvF66d+3XPD7dWrPD8bABs5YI17gsqxZhYQ==@vger.kernel.org X-Gm-Message-State: AFq9FYJGnVnrY/43AmRz/EKuKs1y2Cmg+i995PzVw8OMN+Tn9jixSVU5 /T2EhKYF7oNEbYYmy+IR3yF9iEnRlm5NtHcOdc9ydqE4fo4uViCzi23b X-Gm-Gg: AYBFou1rBzQuP/ev8ClGCZ3dazYE7SG/ThI1YOV8IASdGj6LWCYKuiYzN1SxtJipxUc PATsZRONJCr7yoTJtM9ks2JnPRe/8+TfNNnTi84Vr3gu2O6dXDFE+u2SRC3hvmeElP3/0TQm6VZ +dRGDluvH6on3ydcHr5y5SGMSondhsN4scSpQcH9gbeMdsIcZKYaf2ynS5i5ki0RPgEp2cP/uGt g5KI0gNvlX33+06UUyAkZ5Vxs2PQq4MfGQxl16tL/2rq78pB7W1XcUZNS0KUF9cze0VyQnMzUZg GtokJexWOLLerh4or/8eZoq374c0JyxvW8sh2sRF5xtbpXhaZ7Flpxf6p7zSaecCCfO/31NZG1U G1gaN090qmNWWuw4p7Aw6UaE4IL6I29WwIhRNNe4wOceWsvA0i/YEjCvry/L6aL1QEG5sYZkoAy kcwgryf+fYLmwSir+3CYS4i1cMxLwjI0HigNSImeN+1bL8PYXzvDWY17ugXSu+04JsFcjxGqzdh xD9lqxvKOVBeVBxd9JYlaboS5G6PJZtA54VrY6ID1ez3GH0q0ac X-Received: by 2002:a05:690c:402f:b0:8ae:c015:3e36 with SMTP id 00721157ae682-8b07eebfba0mr45173167b3.50.1792075555970; Thu, 15 Oct 2026 07:45:55 -0700 (PDT) Received: from [10.5.0.2] ([186.247.181.208]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b07f1ea845sm67908267b3.24.2026.10.15.07.45.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 07:45:55 -0700 (PDT) Message-ID: Date: Thu, 15 Oct 2026 08:45:54 -0600 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: nvec: use guard(mutex) in nvec_write_sync() To: Greg Kroah-Hartman , Jeremy Dean Clifton Cc: Marc Dietrich , ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Julia Lawall References: <20261012222926.7754-1-deaner92.ref@yahoo.com> <20261012222926.7754-1-deaner92@yahoo.com> <2026101335-expansive-veteran-c4d6@gregkh> Content-Language: en-US From: Jeremy Dean Clifton In-Reply-To: <2026101335-expansive-veteran-c4d6@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/13/26 12:15 AM, Greg Kroah-Hartman wrote: > On Mon, Oct 12, 2026 at 10:29:26PM +0000, Jeremy Dean Clifton wrote: >> The three return paths of nvec_write_sync() each release >> sync_write_mutex with explicit unlock calls. >> >> Use guard(mutex) to unlock the lock automatically on any return >> path. >> >> This removes the three mutex_unlock() calls. >> >> No functional change. >> >> Signed-off-by: Jeremy Dean Clifton >> --- >> v2: >> - Reword the commit message to state the motivation and to make >> clear that removing the mutex_unlock() calls is the result of >> the change (Julia Lawall). >> v1: https://lore.kernel.org/all/20261012171312.5998-1-deaner92@yahoo.com/ > > Please read the archives for why I will not take guard() rewrites of > staging drivers (nor do I want to see you use a LLM in here either.) > > sorry, > > greg k-h Hello Greg + Everyone, It turns out that I was unknowingly subscribed to this list and started creating patches for the Outreachy group without ever having submitted an application to Outreachy. I just wanted to learn how to contribute to the Linux Kernel and I saw https://kernelnewbies.org/ as a direct connection to Outreachy. While I am technically not part of this cohort, I can still review patches. What is preferred? I assume that the same rules apply outside of Outreachy? No LLMs and no guard() rewrites. Jeremy