public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH v3] ASOC: tegra: move AC97 clock handling to the machine driver
Date: Wed, 19 Mar 2014 00:12:44 +0100	[thread overview]
Message-ID: <e1741f5cc6534f1af897b8817a4a8d73@agner.ch> (raw)
In-Reply-To: <1395174649-1493-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>

Am 2014-03-18 21:30, schrieb Lucas Stach:
> On Tegra the convention is to have a single machine driver
> that's controlling the whole audio subsystem. This was
> introduced after the AC97 driver was merged and ever since
> AC97 has been broken.
> 
> Move the clock handling to the machine driver, to be in line
> with the other Tegra drivers and give the machine driver
> full control over the single Tegra audio PLL.

On a Colibri T20, the AC97 Codec WM9712 gets detected and I can play
audio after unmuting the right output:
amixer -c 0 set 'Left HP Mixer PCM' on
amixer -c 0 set 'Right HP Mixer PCM' on

Tested-by: <stefan-XLVq0VzYD2Y@public.gmane.org>

Lucas, did you tried once to capture input? In my test using arecord -f
cd, recorded sound is very slow (rate problem?)

  parent reply	other threads:[~2014-03-18 23:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 20:30 [PATCH v3] ASOC: tegra: move AC97 clock handling to the machine driver Lucas Stach
     [not found] ` <1395174649-1493-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2014-03-18 23:12   ` Stefan Agner [this message]
2014-03-19 19:34   ` Stephen Warren
     [not found]     ` <5329F161.5080801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-19 19:53       ` Lucas Stach
2014-03-25 18:54   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1741f5cc6534f1af897b8817a4a8d73@agner.ch \
    --to=stefan-xlvq0vzyd2y@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox