[PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Guixin Liu]

When the machine boots using ACPI, Tegra cannot use DMA and falls back
to PIO. In this case, logging these messages as "Error" may confuse
users into thinking it is an actual error; therefore, these two log
messages should be downgraded to "Info" level.

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
 drivers/spi/spi-tegra210-quad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
index 3be7499db21e..2189904b931d 100644
--- a/drivers/spi/spi-tegra210-quad.c
+++ b/drivers/spi/spi-tegra210-quad.c
@@ -823,8 +823,8 @@ static int tegra_qspi_init_dma(struct tegra_qspi *tqspi)
 	tegra_qspi_deinit_dma(tqspi);
 
 	if (err != -EPROBE_DEFER) {
-		dev_err(tqspi->dev, "cannot use DMA: %d\n", err);
-		dev_err(tqspi->dev, "falling back to PIO\n");
+		dev_info(tqspi->dev, "cannot use DMA: %d\n", err);
+		dev_info(tqspi->dev, "falling back to PIO\n");
 		return 0;
 	}
 
-- 
2.43.0

Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Guixin Liu]

Friendly ping...

Best Regards,
Guixin Liu

Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

On Thu, Dec 04, 2025 at 09:46:26AM +0800, Guixin Liu wrote:
> Friendly ping...

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Guixin Liu]

在 2025/12/4 20:33, Mark Brown 写道:
> On Thu, Dec 04, 2025 at 09:46:26AM +0800, Guixin Liu wrote:
>> Friendly ping...
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
>
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.
My bad, sorry for the trouble, and thanks for the advise.

Best Regards,
Guixin Liu

Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Jon Hunter]

On 27/11/2025 13:02, Guixin Liu wrote:
> When the machine boots using ACPI, Tegra cannot use DMA and falls back
> to PIO. In this case, logging these messages as "Error" may confuse
> users into thinking it is an actual error; therefore, these two log
> messages should be downgraded to "Info" level.

Which Tegra device are you using?

> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
>   drivers/spi/spi-tegra210-quad.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
> index 3be7499db21e..2189904b931d 100644
> --- a/drivers/spi/spi-tegra210-quad.c
> +++ b/drivers/spi/spi-tegra210-quad.c
> @@ -823,8 +823,8 @@ static int tegra_qspi_init_dma(struct tegra_qspi *tqspi)
>   	tegra_qspi_deinit_dma(tqspi);
>   
>   	if (err != -EPROBE_DEFER) {
> -		dev_err(tqspi->dev, "cannot use DMA: %d\n", err);
> -		dev_err(tqspi->dev, "falling back to PIO\n");
> +		dev_info(tqspi->dev, "cannot use DMA: %d\n", err);
> +		dev_info(tqspi->dev, "falling back to PIO\n");
>   		return 0;
>   	}

This change would potentially hide an actual case where the DMA 
initialisation fails when booting with device-tree.

Jon

-- 
nvpublic

Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

[Guixin Liu]

在 2025/12/10 12:24, Jon Hunter 写道:
>
> On 27/11/2025 13:02, Guixin Liu wrote:
>> When the machine boots using ACPI, Tegra cannot use DMA and falls back
>> to PIO. In this case, logging these messages as "Error" may confuse
>> users into thinking it is an actual error; therefore, these two log
>> messages should be downgraded to "Info" level.
>
> Which Tegra device are you using?
Tegra194.
The error log are:
     tegra-i2c NVDA0301:00 cannot use DMA: -19
     tegra-i2c NVDA0301:00 failling back to PIO
>
>> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
>> ---
>>   drivers/spi/spi-tegra210-quad.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/spi/spi-tegra210-quad.c 
>> b/drivers/spi/spi-tegra210-quad.c
>> index 3be7499db21e..2189904b931d 100644
>> --- a/drivers/spi/spi-tegra210-quad.c
>> +++ b/drivers/spi/spi-tegra210-quad.c
>> @@ -823,8 +823,8 @@ static int tegra_qspi_init_dma(struct tegra_qspi 
>> *tqspi)
>>       tegra_qspi_deinit_dma(tqspi);
>>         if (err != -EPROBE_DEFER) {
>> -        dev_err(tqspi->dev, "cannot use DMA: %d\n", err);
>> -        dev_err(tqspi->dev, "falling back to PIO\n");
>> +        dev_info(tqspi->dev, "cannot use DMA: %d\n", err);
>> +        dev_info(tqspi->dev, "falling back to PIO\n");
>>           return 0;
>>       }
>
> This change would potentially hide an actual case where the DMA 
> initialisation fails when booting with device-tree.
>
> Jon
>
Could we downgrade this to warning? This will not potentially hide an 
actual DMA fail case, and also tell users that we can still work, don't 
worry.

Best Regards,
Guixin Liu