From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>,
pshete@nvidia.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
bjorn.andersson@oss.qualcomm.com, conor+dt@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, ebiggers@kernel.org,
geert@linux-m68k.org, krzk+dt@kernel.org,
kuninori.morimoto.gx@renesas.com, linusw@kernel.org,
luca.weiss@fairphone.com, michal.simek@amd.com,
prabhakar.mahadev-lad.rj@bp.renesas.com, robh@kernel.org,
rosenp@gmail.com, sven@kernel.org, thierry.reding@kernel.org,
webgeek1234@gmail.com
Subject: Re: [PATCH 6/6] arm64: defconfig: make Tegra238 and Tegra264 Pinctrl a loadable module
Date: Thu, 16 Apr 2026 16:37:36 +0200 [thread overview]
Message-ID: <e3ab5e2d-9ed4-4921-acf4-71109aafcfc8@kernel.org> (raw)
In-Reply-To: <19f390ab-ffa9-4237-9f24-ead07b627a89@nvidia.com>
On 13/04/2026 11:49, Jon Hunter wrote:
>>>> index dd1ac01ee29b..f525670d3b84 100644
>>>> --- a/arch/arm64/configs/defconfig
>>>> +++ b/arch/arm64/configs/defconfig
>>>> @@ -711,6 +711,8 @@ CONFIG_PINCTRL_SC8280XP_LPASS_LPI=m
>>>> CONFIG_PINCTRL_SM8550_LPASS_LPI=m
>>>> CONFIG_PINCTRL_SM8650_LPASS_LPI=m
>>>> CONFIG_PINCTRL_SOPHGO_SG2000=y
>>>> +CONFIG_PINCTRL_TEGRA238=m
>>>> +CONFIG_PINCTRL_TEGRA264=m
>>>
>>> No, you just added as module. Why do we want them in upstream defconfig?
>>>
>>> Standard question, already asked Nvidia more than once.
>>
>> Yes :-)
>>
>> Prathamesh, what we need to do is ...
>>
>> 1. Add a patch to populate the pinctrl DT nodes for Tegra264 device.
>> 2. In this patch, only enable pinctrl for Tegra264 because we are
>> lacking an upstream board for Tegra238 for that moment. In the commit
>> message we should add a comment to indicate with Tegra264 platform is
>> using this.
>
> Thinking about this some more, I think I would prefer that we skip the
> defconfig patch and just add ...
>
> default m if ARCH_TEGRA_238_SOC
>
> default m if ARCH_TEGRA_264_SOC
>
> ... in the respective Kconfig files for the drivers.
I support this, I am trying to do something similar to Qualcomm. None of
core SoC drivers should become a question to the user. We want one
multiplatform image in general, so whoever chooses ARCH_TEGRA or
ARCH_QCOM should get everything (while still being able to disable if
needed).
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-16 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:13 [PATCH 0/6] Add Tegra238 and Tegra264 pinctrl support pshete
2026-04-09 13:13 ` [PATCH 1/6] pinctrl: tegra: Export tegra_pinctrl_probe() pshete
2026-04-09 13:13 ` [PATCH 2/6] dt-bindings: pinctrl: Document Tegra238 pin controllers pshete
2026-04-10 11:00 ` Krzysztof Kozlowski
2026-04-10 11:04 ` Krzysztof Kozlowski
2026-04-09 13:13 ` [PATCH 3/6] pinctrl: tegra: Add Tegra238 pinmux driver pshete
2026-04-10 10:05 ` Krzysztof Kozlowski
2026-04-09 13:13 ` [PATCH 4/6] dt-bindings: pinctrl: Document Tegra264 pin controllers pshete
2026-04-09 13:13 ` [PATCH 5/6] pinctrl: tegra: Add Tegra264 pinmux driver pshete
2026-04-09 13:13 ` [PATCH 6/6] arm64: defconfig: make Tegra238 and Tegra264 Pinctrl a loadable module pshete
2026-04-10 6:37 ` Krzysztof Kozlowski
2026-04-10 8:25 ` Jon Hunter
2026-04-13 9:49 ` Jon Hunter
2026-04-16 14:30 ` Thierry Reding
2026-04-16 14:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ab5e2d-9ed4-4921-acf4-71109aafcfc8@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ebiggers@kernel.org \
--cc=geert@linux-m68k.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=michal.simek@amd.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sven@kernel.org \
--cc=thierry.reding@kernel.org \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox