From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C4677F30 for ; Tue, 16 Apr 2024 07:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252742; cv=none; b=r6SbFQt+TLCWo2Es4+Jg4b4MbLRJtih+tci98J03EesD3kDYTjfjXGVBcGXyvYiSzS7c/ZFYd8kOtam9tVTN2LvEWVkX9tlNAiqQqCkytJYuk8HaKEDwwuoRFyYPKyW3X2LY4S0cpEeR+YSZI9LZly+tgXoKc8/MXo5qf6xeuCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252742; c=relaxed/simple; bh=Cs1dgXPtyii2K9Gr9D0keZ57yvHI7OfDP8UWsuFVXPo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GDCcdgEh3AZXKdmfqBdMF9QhoddEKrOqmIwKdiDXVHDZMDDd56JimCH7qJZgyiP2w8zOAvQkVMNn0fJmM4eZvOxrHNl01DvmWPBjj4peudibgfEHGn+dywxasEtk78rT/r7xANVKsPAjxWqdk0KJVwPWlegDiL+7Cecn9XhXaZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jHdVgNVw; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jHdVgNVw" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a4702457ccbso502993666b.3 for ; Tue, 16 Apr 2024 00:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713252739; x=1713857539; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8R9bVOGo16amHaHdQgn3vohiOg/80cUEYV+3t7qlHzM=; b=jHdVgNVw0xBVycy6FryZ/6a/Xi0qXaubIU5rhNKkprqtgwmPi9meLe5k4zG6cyYM0+ mY7rWYsVMxd3whSYm19DgwcmIc8NovyyQ33uncARihnb9WImpyt1/tUMQKa5UqBBQI01 xYqlJRLWJulSbW1m5uNb2RhM32xcQzwI7X8Z4rENT55gwpQrHd8f95D8E/sDi5JWSDEz 6+7Sw2KGcjHP4AW4DtljQ+oRJZ0wsRQa3Euy/BaYS5P1ihyr8PCverM5GBIGfxhp+AwX ky4CjKOxkjS/mR3Eh0iST5+t9O2wF2V/72j27kIEtnM4yzrrochKOVihGlJtYM5qaQNQ hqKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713252739; x=1713857539; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8R9bVOGo16amHaHdQgn3vohiOg/80cUEYV+3t7qlHzM=; b=EdmroUvUcIgTSA4sRJY/EmEJvBf1Zmq4E+zdkrER3HdERSg5Dfk1973lIcHv5BhCHR UPCIeL5nmiZStOEfjq3QbtvFgC3ozzk1kG7UTkr9ULd4esIx0IAUoO3AIWZnTLYIRdIf J3gW9H/xz6DAhB8MZUbQ6O2F8aOnnKbKA0LjEb3FtGlruxLX/REB24CEb4w45EFwNRYH akMj48psXcWr8QdumwwxMZ1KN6BHKwNVGB4W9u3/G96jawEy7H7mNVQJ5/UJBo+Rats5 GBu8kMeVRcZ9+PDO7pc2glarRwhmYTUOzNToJHbeIaffKVjHiKQVLmh7PT+qdc/ksMBB KKkQ== X-Forwarded-Encrypted: i=1; AJvYcCW3f8seCZiHJ2mSg4rohhADQmRKcpWAe6Afqqi+ggamNdi/YjCM0Xqyy2fHAPFAxUVWfhTLqg6DKA34ONZ3rlRb/3HtqVm3CS4Uvnw= X-Gm-Message-State: AOJu0Yxb3bMZmxJAu9wXKmHlAnLz+ps+9LN6tjkiTBLT2WcrITjRN4dr U1NzwxBMAUgfnl37IXHfSIraSfpNZSEV2QSkZIEN+FKdXetMi2Hd0JdScG73sIM= X-Google-Smtp-Source: AGHT+IEiSwmXJXJlRrwBTxtu6/XHomvPQRR0BAqxebaWeb0WkKlHDct2PHGh5ytZktKV5zyNXHYwQg== X-Received: by 2002:a17:906:57d6:b0:a52:6c4e:25ae with SMTP id u22-20020a17090657d600b00a526c4e25aemr2620587ejr.44.1713252739010; Tue, 16 Apr 2024 00:32:19 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id qb11-20020a1709077e8b00b00a51ab065bf0sm6421883ejc.202.2024.04.16.00.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 00:32:18 -0700 (PDT) Date: Tue, 16 Apr 2024 10:32:14 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 02/35] media: stb0899: Remove unreacheable code Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-2-477afb23728b@chromium.org> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-2-477afb23728b@chromium.org> On Mon, Apr 15, 2024 at 07:34:19PM +0000, Ricardo Ribalda wrote: > chip_id is an unsigned number, it can never be < 0 > > Fixes cocci check: > drivers/media/dvb-frontends/stb0899_drv.c:1280:8-15: WARNING: Unsigned expression compared with zero: chip_id > 0 > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/dvb-frontends/stb0899_drv.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/dvb-frontends/stb0899_drv.c b/drivers/media/dvb-frontends/stb0899_drv.c > index 2f4d8fb400cd..222b5476ebfd 100644 > --- a/drivers/media/dvb-frontends/stb0899_drv.c > +++ b/drivers/media/dvb-frontends/stb0899_drv.c > @@ -1277,11 +1277,6 @@ static int stb0899_get_dev_id(struct stb0899_state *state) > dprintk(state->verbose, FE_ERROR, 1, "Demodulator Core ID=[%s], Version=[%d]", (char *) &demod_str, demod_ver); > CONVERT32(STB0899_READ_S2REG(STB0899_S2FEC, FEC_CORE_ID_REG), (char *)&fec_str); > fec_ver = STB0899_READ_S2REG(STB0899_S2FEC, FEC_VER_ID_REG); > - if (! (chip_id > 0)) { This is not dead code. It's possible for chip_id to be equal to 0. regards, dan carpenter > - dprintk(state->verbose, FE_ERROR, 1, "couldn't find a STB 0899"); > - > - return -ENODEV; > - } > dprintk(state->verbose, FE_ERROR, 1, "FEC Core ID=[%s], Version=[%d]", (char*) &fec_str, fec_ver);