From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice CHOTARD Subject: Re: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE Date: Wed, 31 May 2017 07:11:41 +0000 Message-ID: References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Content-Language: en-US Content-ID: <267EBEA7178F2C4F80A2CFADCAB2FBA3@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Daniel Lezcano , "tglx@linutronix.de" Cc: Mark Rutland , "open list:RALINK MIPS ARCHITECTURE" , Baruch Siach , Heiko Stuebner , Neil Armstrong , Linus Walleij , Santosh Shilimkar , Liviu Dudau , "moderated list:ARM/OXNAS platform support" , Eric Anholt , Thierry Reding , Ingo Molnar , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Florian Fainelli , "moderated list:H8/300 ARCHITECTURE" , Alexander Shiyan , "open list:ARM/Rockchip SoC support" , Kevin List-Id: linux-tegra@vger.kernel.org Hi Daniel On 05/27/2017 11:58 AM, Daniel Lezcano wrote: > The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the > clocksource at early stage. However, this macro is also used to initialize > the clockevent if any, or the clockevent only. > > It was originally suggested to declare another macro to initialize a > clockevent, so in order to separate the two entities even they belong to the > same IP. This was not accepted because of the impact on the DT where splitting > a clocksource/clockevent definition does not make sense as it is a Linux > concept not a hardware description. > > On the other side, the clocksource has not interrupt declared while the > clockevent has, so it is easy from the driver to know if the description is > for a clockevent or a clocksource, IOW it could be implemented at the driver > level. > > So instead of dealing with a named clocksource macro, let's use a more generic > one: TIMER_OF_DECLARE. > > The patch has not functional changes. > > Signed-off-by: Daniel Lezcano > --- [...] > diff --git a/drivers/clocksource/clksrc_st_lpc.c b/drivers/clocksource/clksrc_st_lpc.c > index 03cc492..a1d01eb 100644 > --- a/drivers/clocksource/clksrc_st_lpc.c > +++ b/drivers/clocksource/clksrc_st_lpc.c > @@ -132,4 +132,4 @@ static int __init st_clksrc_of_register(struct device_node *np) > > return ret; > } > -CLOCKSOURCE_OF_DECLARE(ddata, "st,stih407-lpc", st_clksrc_of_register); > +TIMER_OF_DECLARE(ddata, "st,stih407-lpc", st_clksrc_of_register); For the STi driver: Acked-by: Patrice Chotard Thanks