From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH tegra-cbootimage] Add automake option subdir-objects to prevent warnings Date: Mon, 19 Aug 2013 22:18:37 +0200 Message-ID: References: <20130723154918.GB2864@dhcp-172-17-186-34.nvidia.com> <51FAC272.8040105@wwwdotorg.org> <20130819200822.GA13707@badger> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130819200822.GA13707@badger> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Allen Martin Cc: Stephen Warren , Thierry Reding , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Am 2013-08-19 22:08, schrieb Allen Martin: > On Thu, Aug 01, 2013 at 01:17:54PM -0700, Stephen Warren wrote: >> On 07/23/2013 09:49 AM, Thierry Reding wrote: >> > On Sun, Jul 21, 2013 at 11:25:28PM +0200, Stefan Agner wrote: >> >> The SoC specific code is in subdirectories which leads to >> >> warnings in newer automake versions. The option subdir-objects >> >> prevents those warnings. >> >> >> >> Signed-off-by: Stefan Agner --- src/Makefile.am >> >> | 2 ++ 1 file changed, 2 insertions(+) >> >> >> >> diff --git a/src/Makefile.am b/src/Makefile.am index >> >> 6fcc0d8..6fecfc7 100644 --- a/src/Makefile.am +++ >> >> b/src/Makefile.am @@ -1,3 +1,5 @@ +AUTOMAKE_OPTIONS = >> >> subdir-objects + AM_CFLAGS = -Wall -std=c99 >> >> >> >> bin_PROGRAMS = cbootimage bct_dump >> > >> > Hi Stefan, >> > >> > Thanks for the patch. Generally this looks good to me, though >> > automake now complains: >> > >> > src/Makefile.am:36: compiling `t114/parse_t114.c' in subdir >> > requires `AM_PROG_CC_C_O' in `configure.ac' >> > >> > Which can quite easily be solved by adding that line in >> > configure.ac. Immediately following the AC_PROG_CC looks like a >> > good place for it. >> >> Stefan, are you planning on revising the patch based on Thierry's >> suggestion? > > Hi, what's the status of this patch? Is there a version 2 to review? Funny, just sent the updated patch seconds ago! Altough, my mailer says I lost the race by 2 minutes :-( -- Stefan