From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation Date: Wed, 11 Jul 2018 09:42:20 +0100 Message-ID: References: <1531154338-3998-1-git-send-email-avienamo@nvidia.com> <1531154338-3998-3-git-send-email-avienamo@nvidia.com> <5805047f-4099-db34-0759-42e4a9e11629@nvidia.com> <20180711080022.GB1636@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180711080022.GB1636@tbergstrom-lnx.Nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Peter De Schrijver Cc: Aapo Vienamo , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Thierry Reding , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 11/07/18 09:00, Peter De Schrijver wrote: > On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote: >> >> On 09/07/18 17:38, Aapo Vienamo wrote: >>> From: Peter De Schrijver >>> >>> Move this to a separate file so it can be used to calculate the sdmmc >>> clock dividers. >> >> Sorry for not commenting sooner, but what is the motivation for moving >> this to its own file? I don't see why we need to do this in order to use >> elsewhere. Furthermore, the original file is quite aptly named 'clk-divider.c' >> and now we have a div71.c which seems quite specific. > > How else would you do it? Keep it in the same file? Jon -- nvpublic