From: Pelle Windestam <pelle@windestam.se>
To: 胡连勤 <hulianqin@vivo.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Jon Hunter" <jonathanh@nvidia.com>
Cc: Prashanth K <quic_prashk@quicinc.com>,
"mwalle@kernel.org" <mwalle@kernel.org>,
"quic_jjohnson@quicinc.com" <quic_jjohnson@quicinc.com>,
David Brownell <dbrownell@users.sourceforge.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"opensource.kernel" <opensource.kernel@vivo.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Brad Griffis <bgriffis@nvidia.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@gmail.com>
Subject: Re: 答复: [PATCH v3] usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null
Date: Wed, 5 Feb 2025 20:29:26 +0100 [thread overview]
Message-ID: <f264888e-6100-4812-9661-ffad174f45af@windestam.se> (raw)
In-Reply-To: <TYUPR06MB621712E6A082791B397088BFD2F72@TYUPR06MB6217.apcprd06.prod.outlook.com>
>>>>> Odd, you have a usb-serial gadget device in this system that is
>>>>> disconnecting somehow? That oops doesn't point to anything in the
>>>>> usb gadget codebase, "all" we have done is move the call to
>>>>> shutdown the endpoints to earlier in the disconnect function.
>>>>
>>>> Yes the board starts usb-serial and usb-ethernet gadget and on
>>>> reboot when tearing it down I am seeing the above. As soon as it
>>>> disables the tegra-xudc endpoints (as seen above) the board appears to
>> stall.
>>>>
>>>>> I'm glad to revert this, but it feels really odd that this is
>>>>> causing you an rcu stall issue.
>>>>
>>>> Thanks. I can't say I understand it either, but I am certain it is
>>>> caused by this change.
>>>>
I do not have much to add in terms of solutions but want to chime in
that the same issue happened to me the other day when I upgraded my
kernel. It manifests itself with the rcu stall whenever I try to reboot
my device with the USB-cable connected (it is a usb-serial gadget
device). Moving the usb_ep_disable() calls to outside the lock (where
they were before the patch) solves it.
next prev parent reply other threads:[~2025-02-05 19:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <TYUPR06MB621733B5AC690DBDF80A0DCCD2042@TYUPR06MB6217.apcprd06.prod.outlook.com>
2025-01-16 13:11 ` [PATCH v3] usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null Jon Hunter
2025-01-16 13:28 ` gregkh
2025-01-16 15:01 ` Jon Hunter
2025-01-17 5:04 ` 答复: " 胡连勤
2025-01-17 8:24 ` gregkh
2025-01-17 9:48 ` Jon Hunter
2025-01-21 12:19 ` Jon Hunter
2025-01-23 14:56 ` Dan Carpenter
2025-02-05 6:38 ` 答复: " 胡连勤
2025-02-05 19:29 ` Pelle Windestam [this message]
2025-02-06 2:36 ` 答复: " 胡连勤
2025-02-06 4:24 ` Prashanth K
2025-02-06 7:47 ` Pelle Windestam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f264888e-6100-4812-9661-ffad174f45af@windestam.se \
--to=pelle@windestam.se \
--cc=bgriffis@nvidia.com \
--cc=dan.carpenter@linaro.org \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@gmail.com \
--cc=hulianqin@vivo.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_prashk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox