From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853DB4418F2; Fri, 10 Jul 2026 16:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702172; cv=none; b=EDd6VO57MFOS+wFg0IsWdPXRvTtX2ezN+/m1kle0/mnWGapz8WKUQDm/7vbE+nem+vyPfqte3RHW6f2v8F4HzRxz4cysV7vBU7GnUDpwQJIvCyb0V37VbMXHD2q3u2cltSD399EoPeP44pwbLFun7TXVjpAXgMv0TLmE9qk36E8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702172; c=relaxed/simple; bh=LIWX7JGoFjuB4lkn5HoQseNyWV/4TB8Hwgp7oMlg2a8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u1IWjHI8jp6ne0hHl4jGurCUuYHQUvVL1mdpSvPo1of6vLFiGdztte2lky0y5FNyc2wcGgZuJDeow81vrwVJgnQ25F/cF6jXfuhXwMYQszPrBV4Ck7yCMQ8iyMWjVPklajv+oRCBPpeCxaqRZnT4n9xNbFLZXvm/Ueuzka3x8BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=yqGM8TC8; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="yqGM8TC8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ctpw6H5oitgKah3XmofQDzLZrombiT2hiX7qbOqdOHA=; b=yqGM8TC8D5G63SEgrNyIFMo1ni YHDUODa82SvLG5OFbeYUUtoHPcmMBgGi901C2tNI6+g6WketgPWn3kh6zM/OHkG3cDbrXl3rwJGlX Rco81EFU5kClMmBr05IrxW44tUdOQZKovbC+8sf8SYbOqt6hr9HLueV3hFlX22J5Pthg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wiEPe-00Bfjf-3w; Fri, 10 Jul 2026 18:49:18 +0200 Date: Fri, 10 Jul 2026 18:49:18 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: vadik likholetov , netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thierry Reding , Jonathan Hunter , Bhadram Varka , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: stmmac: enable the MAC on link up at 10G on 10GBASE-R Message-ID: References: <20260710120908.3731591-1-vadikas@gmail.com> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I suggest that instead of this fix (that is ommiting the 5G case btw), we rewrite > the whole ctrl assignment as : > > switch (speed) { > case SPEED_100000: > ctrl |= priv->hw->link.xlgmii.speed100000; > break; > case SPEED_50000: > ctrl |= priv->hw->link.xlgmii.speed50000; > break; > case SPEED_40000: > ctrl |= priv->hw->link.xlgmii.speed40000; > break; > case SPEED_25000: > ctrl |= priv->hw->link.xlgmii.speed25000; > break; > case SPEED_10000: > ctrl |= priv->hw->link.xgmii.speed10000; > break; > case SPEED_5000: > ctrl |= priv->hw->link.xgmii.speed5000; > break; > case SPEED_2500: > if (interface == PHY_INTERFACE_MODE_USXGMII) > ctrl |= priv->hw->link.xgmii.speed2500; > else > ctrl |= priv->hw->link.speed2500; > break; > case SPEED_1000: > ctrl |= priv->hw->link.speed1000; > case SPEED_100: > ctrl |= priv->hw->link.speed100; > break; > case SPEED_10: > ctrl |= priv->hw->link.speed10; > break; > default: > return; > } The bug description makes it sound like it was not obvious to debug. So maybe put an error message in the default: to aid the next developer who hits it with SPEED_14000, or whatever comes next. Andrew