From mboxrd@z Thu Jan 1 00:00:00 1970 From: Faiz Abbas Subject: Re: [PATCH 2/3] mmc: sdhci-omap: drop ->get_ro() implementation Date: Fri, 18 Jan 2019 16:27:11 +0530 Message-ID: References: <20190115162837.5399-1-thomas.petazzoni@bootlin.com> <20190115162837.5399-3-thomas.petazzoni@bootlin.com> <20190116132747.GB11050@ulmo> <20190116154717.GQ5544@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190116154717.GQ5544@atomide.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren , Thierry Reding Cc: Thomas Petazzoni , Adrian Hunter , Kishon Vijay Abraham I , Ulf Hansson , Jonathan Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Gregory Clement , linux-omap@vger.kernel.org List-Id: linux-tegra@vger.kernel.org Tony, On 16/01/19 9:17 PM, Tony Lindgren wrote: > * Thierry Reding [190116 13:28]: >> On Tue, Jan 15, 2019 at 05:28:36PM +0100, Thomas Petazzoni wrote: >>> The SDHCI core is know properly checking for the state of a WP GPIO, >> >> "know" -> "now" >> >>> so there is no longer any need for the sdhci-omap code to implement >>> ->get_ro() using mmc_gpio_get_ro(). >>> >>> Signed-off-by: Thomas Petazzoni >>> --- >>> Note: this patch has only been compiled tested, as I don't have the >>> hardware to test it. >>> --- >>> drivers/mmc/host/sdhci-omap.c | 1 - >>> 1 file changed, 1 deletion(-) >> >> I can't runtime test this myself, but it certainly looks like this would >> do the right thing because it calls the core now call the very same >> function as this used to, so: >> >> Reviewed-by: Thierry Reding >> >> Adding Tony and linux-omap for a slightly wider audience and hopefully >> find someone to test this on. For reference, the whole series is here: >> >> https://patchwork.kernel.org/project/linux-mmc/list/?series=66905 > > Thanks Kishon can you please review and test? > I can help with testing once Thomas posts a v2. Thanks, Faiz