From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 Date: Fri, 10 Apr 2020 23:46:25 +0300 Message-ID: References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200409175238.3586487-10-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > --- > Changes in v6: > - use __maybe_unused instead of #ifdef'ery for suspend/resume callbacks > - take exclusive control of EMC clock during suspend/resume > - move EMC driver changes from clk patch to this patch > - make the driver buildable as a module > - remove unnecessary suspend tracking > - remove duplicate register defines > - add tegra210-emc.h for Tegra210-specific registers > - detect number of channels, number of devices and DRAM type at probe > time and store them in struct tegra210_emc, remove the corresponding > function parameters where no longer needed > - properly clean up on failure > > Changes in v5: > - major rework and cleanup I happened to notice that the patches have an individual changelog only by accident :) Next time will be nice if at least you could mention about this in the cover-letter, or move (or duplicate) the whole log in the cover-letter.