From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
kernel test robot <lkp@intel.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison
Date: Thu, 29 Aug 2024 12:14:41 +0300 [thread overview]
Message-ID: <feb9dcf0-0249-41b9-bad0-c988ad2e45db@stanley.mountain> (raw)
In-Reply-To: <kh4diauo5u63mldchmd66pbnqxwnbqfoqcpxsw6wwocbadygvz@3diccu2xt4kj>
On Wed, Aug 28, 2024 at 11:44:20PM +0300, Dmitry Baryshkov wrote:
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > > Closes: https://lore.kernel.org/r/202408110724.8pqbpDiD-lkp@intel.com/
>
> this Closes tag must come after lkp's Reported-by. Please also add
> Closes with the link to Dan's report.
>
No, this one is okay. What happens is with some Smatch warnings, the bot
sends the email to me, I look it over and either discard or forward it on so
we get two Reported-bys for one email.
> >
> > There is also the above smatch warning that was reported.
>
> And the Smatch warning too should be a part of the commit message.
>
> Last, but not least, as it is a fix, there should be a Fixes: tag and
> optionally a cc:stable.
>
To be fair, at the time no one thought this was a Fix, just a cleanup.
regards,
dan carpenter
next prev parent reply other threads:[~2024-08-29 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240813094035.974317-1-quic_skakitap@quicinc.com>
[not found] ` <4d314b61-7483-4ceb-ac72-10dbd7e4522a@linaro.org>
2024-08-28 13:47 ` [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison Jon Hunter
2024-08-28 20:44 ` Dmitry Baryshkov
2024-08-29 9:14 ` Dan Carpenter [this message]
2024-08-30 5:33 ` Satya Priya Kakitapalli
2024-09-04 21:26 ` Jon Hunter
2024-09-05 10:58 ` Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb9dcf0-0249-41b9-bad0-c988ad2e45db@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox