[PATCH] tegra/mmc: add pm_flags

[PATCH] tegra/mmc: add pm_flags

[Grant Grundler]

Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.

This part allows the mach-tegra support tell the tegra MMC host controller
to NOT turn off power for the MMC controller the WIFI part lives behind.
Thus bcm4329 firmware doesn't need to be reloaded.

Signed-off-by: Venkat Rao <vrao@broadcom>
Tested-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Olof Johansson <olofj@chromium.org>
----
I'm not certain if this should go through tegra or mmc tree.
Can you advise please?

This is part of http://codereview.chromium.org/6474032 .
The other three change sets required for Seaboard (Tegra2):
    http://codereview.chromium.org/6484021
    http://codereview.chromium.org/6488018
    http://codereview.chromium.org/6489022


diff --git a/arch/arm/mach-tegra/include/mach/sdhci.h b/arch/arm/mach-tegra/include/mach/sdhci.h
index 3ad086e..4231bc7 100644
--- a/arch/arm/mach-tegra/include/mach/sdhci.h
+++ b/arch/arm/mach-tegra/include/mach/sdhci.h
@@ -24,6 +24,7 @@ struct tegra_sdhci_platform_data {
 	int wp_gpio;
 	int power_gpio;
 	int is_8bit;
+	int pm_flags;
 };
 
 #endif
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index f7e1f96..343c97e 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -184,6 +184,8 @@ static int tegra_sdhci_pltfm_init(struct sdhci_host *host,
 	clk_enable(clk);
 	pltfm_host->clk = clk;
 
+	host->mmc->pm_caps = plat->pm_flags;
+
 	if (plat->is_8bit)
 		host->mmc->caps |= MMC_CAP_8_BIT_DATA;
 

Re: [PATCH] tegra/mmc: add pm_flags

[Chris Ball]

Hi,

On Fri, Mar 25 2011, Grant Grundler wrote:
> Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.
>
> This part allows the mach-tegra support tell the tegra MMC host controller
> to NOT turn off power for the MMC controller the WIFI part lives behind.
> Thus bcm4329 firmware doesn't need to be reloaded.
>
> Signed-off-by: Venkat Rao <vrao@broadcom>
> Tested-by: Grant Grundler <grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Reviewed-by: Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ----
> I'm not certain if this should go through tegra or mmc tree.
> Can you advise please?

I'm happy to take it through the MMC tree for .40, but would like
an Acked-by: from an arch/arm/mach-tegra maintainer to show Linus.
Olof is one such person, so getting an Acked-by from him would work.

(Also, Venkat's e-mail address is malformed in the S-o-b.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] tegra/mmc: add pm_flags

[Olof Johansson]

[Gah, now without HTML formatting.]

On Fri, Mar 25, 2011 at 5:07 PM, Grant Grundler <grundler@google.com> wrote:
>
> Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.
>
> This part allows the mach-tegra support tell the tegra MMC host controller
> to NOT turn off power for the MMC controller the WIFI part lives behind.
> Thus bcm4329 firmware doesn't need to be reloaded.
>
> Signed-off-by: Venkat Rao <vrao@broadcom>
> Tested-by: Grant Grundler <grundler@chromium.org>
> Reviewed-by: Olof Johansson <olofj@chromium.org>
> ----
> I'm not certain if this should go through tegra or mmc tree.
> Can you advise please?

Chris, please take it through the MMC tree.

Feel free to s/olofj@chromium.org/olof@lixom.net/ above, either way works.

-Olof

Re: [PATCH] tegra/mmc: add pm_flags

[Olof Johansson]

On Fri, Mar 25, 2011 at 5:27 PM, Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> On Fri, Mar 25 2011, Grant Grundler wrote:
>> Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.
>>
>> This part allows the mach-tegra support tell the tegra MMC host controller
>> to NOT turn off power for the MMC controller the WIFI part lives behind.
>> Thus bcm4329 firmware doesn't need to be reloaded.
>>
>> Signed-off-by: Venkat Rao <vrao@broadcom>
>> Tested-by: Grant Grundler <grundler@chromium.org>
>> Reviewed-by: Olof Johansson <olofj@chromium.org>
>> ----
>> I'm not certain if this should go through tegra or mmc tree.
>> Can you advise please?
>
> I'm happy to take it through the MMC tree for .40, but would like
> an Acked-by: from an arch/arm/mach-tegra maintainer to show Linus.
> Olof is one such person, so getting an Acked-by from him would work.
>
> (Also, Venkat's e-mail address is malformed in the S-o-b.)

Acked-by: Olof Johansson <olof@lixom.net>


-Olof

Re: [PATCH] tegra/mmc: add pm_flags

[Chris Ball]

Hi Grant,

On Fri, Mar 25 2011, Grant Grundler wrote:
> Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.
>
> This part allows the mach-tegra support tell the tegra MMC host controller
> to NOT turn off power for the MMC controller the WIFI part lives behind.
> Thus bcm4329 firmware doesn't need to be reloaded.
>
> Signed-off-by: Venkat Rao <vrao@broadcom>
> Tested-by: Grant Grundler <grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Reviewed-by: Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

One more thing -- who wrote this patch?  If Venkat, it should have a:

From: Venkat Rao <vrao-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

line in either the mail headers or the message body.  If you, it should
have your S-o-b.  The way you've sent it tells Git that you wrote the
patch.

Thanks,

- Chris.
-- 
Chris Ball   <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] tegra/mmc: add pm_flags

[Grant Grundler]

On Fri, Mar 25, 2011 at 5:43 PM, Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> wrote:
> Hi Grant,
>
> On Fri, Mar 25 2011, Grant Grundler wrote:
>> Enable fast bcm4329 WIFI suspend/resume on Tegra2 board.
>>
>> This part allows the mach-tegra support tell the tegra MMC host controller
>> to NOT turn off power for the MMC controller the WIFI part lives behind.
>> Thus bcm4329 firmware doesn't need to be reloaded.
>>
>> Signed-off-by: Venkat Rao <vrao@broadcom>
>> Tested-by: Grant Grundler <grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> Reviewed-by: Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> One more thing -- who wrote this patch?  If Venkat, it should have a:
>
> From: Venkat Rao <vrao-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

Yes, Venkat wrote it which is why it has his S-o-b line listed first.

> line in either the mail headers or the message body.  If you, it should
> have your S-o-b.  The way you've sent it tells Git that you wrote the
> patch.

Sorry about that. Can you please add the "From" line you've shown
above since it's clearly Venkat's.

thanks!
grant

Re: [PATCH] tegra/mmc: add pm_flags

[Chris Ball]

Hi,

On Fri, Mar 25 2011, Grant Grundler wrote:
> Sorry about that. Can you please add the "From" line you've shown
> above since it's clearly Venkat's.

Done, thanks.

- Chris.
-- 
Chris Ball   <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>   <http://printf.net/>
One Laptop Per Child