From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614E4C4160E for ; Wed, 3 Mar 2021 03:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A00364DD8 for ; Wed, 3 Mar 2021 03:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443400AbhCCDby (ORCPT ); Tue, 2 Mar 2021 22:31:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:39194 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345719AbhCBUZg (ORCPT ); Tue, 2 Mar 2021 15:25:36 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E00FFAE72; Tue, 2 Mar 2021 17:23:03 +0000 (UTC) Date: Tue, 02 Mar 2021 18:23:03 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Jon Hunter , linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present In-Reply-To: <20210302124913.GC4522@sirena.org.uk> References: <20210302092712.310705-1-jonathanh@nvidia.com> <20210302124913.GC4522@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, 02 Mar 2021 13:49:13 +0100, Mark Brown wrote: > > On Tue, Mar 02, 2021 at 09:27:12AM +0000, Jon Hunter wrote: > > Many systems do not provide a DMI table and on these systems a warning, > > such as the following, is printed on boot ... > > > > WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! > > > > If DMI support is enabled in the kernel, there is no simple way to > > detect if a DMI table is table or not. Note that the variable > > 'dmi_available' is not exported and so cannot be used by kernel modules. > > We could fix that, or provide an accessor function? Or only warn if > we're on an ACPI system (which we can check from a module). This really > does feel like something we should be warning about on systems that are > supposed to have DMI information available as standard. I had the same feeling when I took a look at the patch, but later changed mind, since the error will pop up also if a system has an unmatured BIOS with some bogus vendor DMI string, too. That is, users of such a machine gets always an error message although this isn't any serious problem unless you need a dedicated UCM profile (which can't be used on such a system in anyway). So, I agree that exporting dmi_avilable could improve the situation a bit, but the error level needs still reconsideration. Takashi