From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM Date: Wed, 13 Mar 2019 11:29:00 +0100 Message-ID: References: <20190304203337.1968705-1-arnd@arndb.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190304203337.1968705-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Thierry Reding , Jonathan Hunter , Jaroslav Kysela , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Mohan Kumar D , Ravindra Lokhande , Sameer Pujar , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On Mon, 04 Mar 2019 21:33:25 +0100, Arnd Bergmann wrote: > > The #ifdef protection around the PM functions is wrong, leading to > a failed reference in some configurations: > > sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend': > sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration] > > Better remove the #ifdefs entirely and rely on the compiler silently > dropping unused functions marked __maybe_unused. > > Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume") > Signed-off-by: Arnd Bergmann Applied now. Thanks. Takashi