From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2E8C48BDF for ; Fri, 18 Jun 2021 23:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 857FB613BD for ; Fri, 18 Jun 2021 23:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235222AbhFRXyk (ORCPT ); Fri, 18 Jun 2021 19:54:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232678AbhFRXyk (ORCPT ); Fri, 18 Jun 2021 19:54:40 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D262C061574 for ; Fri, 18 Jun 2021 16:52:28 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id g4so6670028pjk.0 for ; Fri, 18 Jun 2021 16:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3QYcwvtyhPnU4XufKlxXAbadnyn0yvfQI9M4GTCqOZc=; b=cPWHs2b8m52BLZv7t3tqRbKyB9koU8IBShogTCNe8qX3i2zUvDaiwjUXulMd1ZUCPG cyQpL+ovwPpT1u7E04n2hxuP7GXYtcFNFxH9lnpykwL/IUzXZE4Wm0IMFBST2on5ZHPp HTSMSMuLbTFMiAUKrtAwuBTjXROUp89Bxf9OwMgbrYyS0A0l74O0jJwIUWr/Rspfgkrl cbTcOKVfxnCRZdLfmT7bQmscPIVq1R8uJHW7AWBkdcyXmpbN4kdOR1ET+nttQr8oIT8/ hn/4oBYYRnHQyU6Af9CEtlGl64Y6sR+79s4pdnxLoXhE1MVUmy+yI3BjLaJge4PSyb/H fBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3QYcwvtyhPnU4XufKlxXAbadnyn0yvfQI9M4GTCqOZc=; b=IfZiq1bMtmHWTNlc9gjDOjB5UoqSp8kuLPQcXeLlEv4qRE0lBd4a9Z5nIKZwPLQJql M9h3ZnBbUoCPveftixFfYyOktVpIoUlCYg6Vo4NKRXprOkII/xwRUsJDxQC4f0nhbIGw womcFKim3rQMCTJUJvDQAhyNIsiZDqdLfMurcrAbCTmYrOAUkI7SPuyegN+elh1RtCni /de1lWXt13ucJu7wHBYOBCnx2P/Ib2L2MGQrbLA44cxgq5/xuMhIwjEAVkTTt3BajBmy L2a3UK/fehURC2F73iCJMpdVhTr3qU1SwlWFbTJrgVdw1aeRyZv6nBIYrfGQm24tGocX O+hw== X-Gm-Message-State: AOAM5305O/yzUPRe1VglqdAZsaeGC+V8OyRh2+DWMXNTU3hbW7Z2MTM3 tY9q4LZRAfsRLX6eBPEOvNSn9A== X-Google-Smtp-Source: ABdhPJxkmDEDb99V5Rag5bSuyb8OzH3uPgagDn2It+ROt3XsV+7Qz1fE4DIvkZKbvuXxca1yWN9nTg== X-Received: by 2002:a17:90b:1946:: with SMTP id nk6mr6004677pjb.86.1624060347511; Fri, 18 Jun 2021 16:52:27 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:7718:8bff:acab:aa6b]) by smtp.gmail.com with ESMTPSA id x22sm8897487pjp.37.2021.06.18.16.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 16:52:26 -0700 (PDT) Date: Fri, 18 Jun 2021 16:52:22 -0700 From: Fangrui Song To: Nick Desaulniers Cc: Kees Cook , Peter Zijlstra , Bill Wendling , Sami Tolvanen , Peter Oberparleiter , Masahiro Yamada , Miguel Ojeda , Nathan Chancellor , Luc Van Oostenryck , Ard Biesheuvel , Will Deacon , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Borislav Petkov , Martin Liska , Marco Elver , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, Dmitry Vyukov , johannes.berg@intel.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO Message-ID: <20210618235222.s6l552hpkbfod6sv@google.com> References: <20210618233023.1360185-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210618233023.1360185-1-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On 2021-06-18, Nick Desaulniers wrote: >When we say noinstr, we mean noinstr. GCOV and PGO can both instrument >functions. Add a new function annotation __no_profile that expands to >__attribute__((__no_profile__)) and Kconfig value >CC_HAS_NO_PROFILE_FN_ATTR. > >Base is >https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/clang/pgo. > >Nick Desaulniers (2): > compiler_attributes.h: define __no_profile, add to noinstr > Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO > > include/linux/compiler_attributes.h | 12 ++++++++++++ > include/linux/compiler_types.h | 2 +- > init/Kconfig | 3 +++ > kernel/gcov/Kconfig | 1 + > kernel/pgo/Kconfig | 3 ++- > 5 files changed, 19 insertions(+), 2 deletions(-) > > >base-commit: 4356bc4c0425c81e204f561acf4dd0095544a6cb >-- >2.32.0.288.g62a8d224e6-goog > Thanks for the attribute work in clang and kernel! Hope we can use clang PGO in 5.14... (I am a casual contributor to clang PGO/coverage)