From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3010C433F5 for ; Fri, 15 Apr 2022 14:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239884AbiDOOOw (ORCPT ); Fri, 15 Apr 2022 10:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354298AbiDOOOv (ORCPT ); Fri, 15 Apr 2022 10:14:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 376E7CC534 for ; Fri, 15 Apr 2022 07:12:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4E526209A for ; Fri, 15 Apr 2022 14:12:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5758C385A6; Fri, 15 Apr 2022 14:12:20 +0000 (UTC) Date: Fri, 15 Apr 2022 10:12:17 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: x86@kernel.org, Josh Poimboeuf , hjl.tools@gmail.com, ndesaulniers@google.com, mbenes@suse.cz, linux-toolchains@vger.kernel.org Subject: Re: The trouble with __weak and objtool got worse Message-ID: <20220415101217.2ea62984@rorschach.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Fri, 15 Apr 2022 13:19:04 +0200 Peter Zijlstra wrote: > This problem affects everything where we have external tools (mostly > objtool but possible also recordmcount) generate location sections for > us, notably things like: > > .static_call_sites > .retpoline_sites > __mcount_loc > .orc_unwind > .orc_unwind_ip But this is only an issue with newer compilers/linkers right? For the case of recordmcount(), that is done pretty much entirely via the compiler these days, so it is likely not an issue. We probably need to have a way to tell the compiler about external references. Or perhaps have an external tool to look at the weak functions that are overridden and be able to handle it appropriately? -- Steve