From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, hjl.tools@gmail.com, ndesaulniers@google.com,
mbenes@suse.cz, rostedt@goodmis.org,
linux-toolchains@vger.kernel.org
Subject: Re: The trouble with __weak and objtool got worse
Date: Fri, 15 Apr 2022 08:15:29 -0700 [thread overview]
Message-ID: <20220415151529.esh5m42nj3oexoff@treble> (raw)
In-Reply-To: <20220415151014.dv4bougij3tqvozp@treble>
On Fri, Apr 15, 2022 at 08:10:18AM -0700, Josh Poimboeuf wrote:
> On Fri, Apr 15, 2022 at 01:19:04PM +0200, Peter Zijlstra wrote:
> > Now, if we do IBT/LTO builds, and run objtool on linked objects only,
> > this obvious doesn't happen, because the weak stuff has been resolved by
> > then. But ideally we'd not force that since it has a build time
> > penalty..
> >
> > The other option seems to be to have objtool add section symbols it
> > needs, however due to ELF being a total PITA and requiring all LOCAL
> > symbols to be before GLOBAL symbols, this would mean re-ordering the
> > whole symbol table (I have the code somewhere :-/).
> >
> > Alternatively:
> >
> > https://sourceware.org/pipermail/binutils/2020-December/114671.html
> >
> > seems to suggest: -Wa,--generate-unused-section-symbols=yes, ought to
> > work, except I'm getting:
> >
> > $ gcc -O2 -fcf-protection=none -fno-asynchronous-unwind-tables -Wa,--generate-unused-section-symbols=yes -c foo*.c
> > as: unrecognized option '--generate-unused-section-symbols=yes'
> > as: unrecognized option '--generate-unused-section-symbols=yes'
> >
> > $ as --version
> > GNU assembler (GNU Binutils for Debian) 2.38
>
> Can we trick the assembler into creating function symbols for all the
I meant s/function symbols/section symbols/ obviously.
> static call sites by having some inline asm (or _THIS_IP_) in the static
> call macro with a dummy reference to a code location in the function?
--
Josh
next prev parent reply other threads:[~2022-04-15 15:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 11:19 The trouble with __weak and objtool got worse Peter Zijlstra
2022-04-15 14:12 ` Steven Rostedt
2022-04-15 15:31 ` Peter Zijlstra
2022-04-15 15:10 ` Josh Poimboeuf
2022-04-15 15:15 ` Josh Poimboeuf [this message]
2022-04-15 15:26 ` Peter Zijlstra
2022-04-15 17:40 ` Nick Desaulniers
2022-04-15 18:21 ` Josh Poimboeuf
2022-04-15 18:23 ` Josh Poimboeuf
2022-04-15 20:36 ` Nick Desaulniers
2022-04-16 10:49 ` Peter Zijlstra
2022-04-16 10:48 ` Peter Zijlstra
2022-04-16 16:07 ` Josh Poimboeuf
2022-04-16 16:32 ` H.J. Lu
2022-04-17 15:44 ` Peter Zijlstra
2022-04-17 15:46 ` Peter Zijlstra
2022-04-15 18:22 ` Segher Boessenkool
2022-04-15 18:36 ` Nick Desaulniers
2022-04-15 20:07 ` Segher Boessenkool
2022-04-15 20:31 ` Nick Desaulniers
2022-04-15 21:17 ` Fangrui Song
2022-04-15 21:41 ` Segher Boessenkool
2022-04-16 11:09 ` Peter Zijlstra
2022-04-16 10:59 ` Peter Zijlstra
2022-04-16 13:20 ` Segher Boessenkool
2022-04-16 17:59 ` Segher Boessenkool
2022-04-15 21:04 ` H.J. Lu
2022-04-16 11:25 ` Peter Zijlstra
2022-04-16 16:27 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415151529.esh5m42nj3oexoff@treble \
--to=jpoimboe@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=linux-toolchains@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).