From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org,
Indu Bhagat <indu.bhagat@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-toolchains@vger.kernel.org, Jordan Rome <jordalgo@meta.com>,
Sam James <sam@gentoo.org>,
linux-trace-kernel@vger.kerne.org,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jens Remus <jremus@linux.ibm.com>,
Florian Weimer <fweimer@redhat.com>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v3 11/19] unwind: Add deferred user space unwinding API
Date: Wed, 30 Oct 2024 15:58:16 -0400 [thread overview]
Message-ID: <20241030155816.094edca5@rorschach.local.home> (raw)
In-Reply-To: <20241030140324.GM14555@noisy.programming.kicks-ass.net>
On Wed, 30 Oct 2024 15:03:24 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> You're designing things inside out again. You should add functionality
> by adding layers.
>
> Pass a void * into the 'request-unwind' and have the 'do-unwind'
> callback get that same pointer. Then anybody that needs identifiers to
> figure out where things came from can stuff something in there.
What the hell should I do with a void pointer? I want a stack trace, I
ask for one, it gives me an identifier for it, then at the end when it
does my callback it gives me the stack trace I asked for with the
identifier that it belongs to.
The identifier should be part of the unwinder code as it has to do with
the stack trace and has nothing to do with tracing.
-- Steve
next prev parent reply other threads:[~2024-10-30 19:58 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:47 [PATCH v3 00/19] unwind, perf: sframe user space unwinding Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 01/19] x86/vdso: Fix DWARF generation for getrandom() Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 02/19] x86/asm: Avoid emitting DWARF CFI for non-VDSO Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-30 17:19 ` Jens Remus
2024-10-30 17:51 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 03/19] x86/asm: Fix VDSO DWARF generation with kernel IBT enabled Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 04/19] x86/vdso: Use SYM_FUNC_{START,END} in __kernel_vsyscall() Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 05/19] x86/vdso: Use CFI macros in __vdso_sgx_enter_enclave() Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 06/19] x86/vdso: Enable sframe generation in VDSO Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-30 18:20 ` Jens Remus
2024-10-30 19:17 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 07/19] unwind: Add user space unwinding API Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-12-06 10:29 ` Jens Remus
2024-12-09 20:54 ` Josh Poimboeuf
2024-12-11 14:53 ` Jens Remus
2024-12-11 17:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 08/19] unwind/x86: Enable CONFIG_HAVE_UNWIND_USER_FP Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-29 13:13 ` Peter Zijlstra
2024-10-29 16:31 ` Josh Poimboeuf
2024-10-29 18:08 ` Peter Zijlstra
2024-10-28 21:47 ` [PATCH v3 09/19] unwind: Introduce sframe user space unwinding Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-29 13:27 ` Peter Zijlstra
2024-10-29 16:50 ` Josh Poimboeuf
2024-10-29 18:10 ` Peter Zijlstra
2024-10-29 23:32 ` Andrii Nakryiko
2024-10-30 5:53 ` Josh Poimboeuf
2024-10-31 20:57 ` Andrii Nakryiko
2024-10-31 21:00 ` Nick Desaulniers
2024-10-31 21:38 ` Indu Bhagat
2024-11-01 18:38 ` Andrii Nakryiko
2024-11-01 18:47 ` Steven Rostedt
2024-11-01 18:54 ` Andrii Nakryiko
2024-11-03 0:07 ` Indu Bhagat
2024-10-31 23:03 ` Josh Poimboeuf
2024-11-01 18:34 ` Andrii Nakryiko
2024-11-01 19:29 ` Josh Poimboeuf
2024-11-01 19:44 ` Andrii Nakryiko
2024-11-01 19:46 ` Andrii Nakryiko
2024-11-01 19:51 ` Josh Poimboeuf
2024-11-01 19:09 ` Segher Boessenkool
2024-11-01 19:33 ` Josh Poimboeuf
2024-11-01 19:35 ` Josh Poimboeuf
2024-11-01 19:48 ` Josh Poimboeuf
2024-11-01 21:35 ` Segher Boessenkool
2024-11-05 17:40 ` Steven Rostedt
2024-11-05 17:45 ` Steven Rostedt
2024-11-06 17:04 ` Jens Remus
2024-11-07 8:25 ` Weinan Liu
2024-11-07 16:59 ` Jens Remus
2024-11-13 20:50 ` Steven Rostedt
2024-11-13 21:15 ` Josh Poimboeuf
2024-11-13 22:13 ` Steven Rostedt
2024-11-13 22:21 ` Steven Rostedt
2024-11-13 22:25 ` Steven Rostedt
2024-11-14 9:57 ` Jens Remus
2024-11-13 15:56 ` Jens Remus
2024-11-13 20:50 ` Steven Rostedt
2024-11-13 21:13 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 10/19] unwind/x86: Enable CONFIG_HAVE_UNWIND_USER_SFRAME Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-29 13:14 ` Peter Zijlstra
2024-10-28 21:47 ` [PATCH v3 11/19] unwind: Add deferred user space unwinding API Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-29 13:48 ` Peter Zijlstra
2024-10-29 16:51 ` Josh Poimboeuf
2024-10-29 13:49 ` Peter Zijlstra
2024-10-29 17:05 ` Josh Poimboeuf
2024-10-29 18:11 ` Peter Zijlstra
2024-10-29 13:56 ` Peter Zijlstra
2024-10-29 17:17 ` Josh Poimboeuf
2024-10-29 17:47 ` Mathieu Desnoyers
2024-10-29 18:20 ` Peter Zijlstra
2024-10-30 6:17 ` Steven Rostedt
2024-10-30 14:03 ` Peter Zijlstra
2024-10-30 19:58 ` Steven Rostedt [this message]
2024-10-30 20:48 ` Josh Poimboeuf
2024-10-29 18:34 ` Josh Poimboeuf
2024-10-30 13:44 ` Mathieu Desnoyers
2024-10-30 17:47 ` Josh Poimboeuf
2024-10-30 17:55 ` Josh Poimboeuf
2024-10-30 18:25 ` Josh Poimboeuf
2024-10-29 23:32 ` Andrii Nakryiko
2024-10-30 6:10 ` Josh Poimboeuf
2024-10-31 21:22 ` Andrii Nakryiko
2024-10-31 23:13 ` Josh Poimboeuf
2024-10-31 23:28 ` Andrii Nakryiko
2024-11-01 17:41 ` Josh Poimboeuf
2024-11-01 18:05 ` Andrii Nakryiko
2024-10-28 21:47 ` [PATCH v3 12/19] perf: Remove get_perf_callchain() 'init_nr' argument Josh Poimboeuf
2024-10-28 21:47 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 13/19] perf: Remove get_perf_callchain() 'crosstask' argument Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 14/19] perf: Simplify get_perf_callchain() user logic Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 15/19] perf: Add deferred user callchains Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-29 14:06 ` Peter Zijlstra
2024-11-06 9:45 ` Jens Remus
2024-10-28 21:47 ` [PATCH v3 16/19] perf tools: Minimal CALLCHAIN_DEFERRED support Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 17/19] perf record: Enable defer_callchain for user callchains Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 18/19] perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 19/19] perf tools: Merge deferred user callchains Josh Poimboeuf
2024-10-28 21:48 ` Josh Poimboeuf
2024-10-28 21:47 ` [PATCH v3 00/19] unwind, perf: sframe user space unwinding Josh Poimboeuf
2024-10-28 21:54 ` Josh Poimboeuf
2024-10-28 23:55 ` Josh Poimboeuf
2024-10-29 14:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030155816.094edca5@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=broonie@kernel.org \
--cc=fweimer@redhat.com \
--cc=indu.bhagat@oracle.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jordalgo@meta.com \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux-trace-kernel@vger.kerne.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sam@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).