From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E86FD259C8A; Wed, 21 May 2025 11:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747825815; cv=none; b=tSpMvuv9OXr0/77l2Rzv/Dpsp3fhvD+mrq0qtIEyhgo+7Wb+V3cnCG+GMpiBKel+G8ntSKnI5ULP7fgTydC5ETacPn0xu0NMM3e/mhkOt0bjubslgcqIcHP9aO69zFOuRM7mVX+bBACWxlpPlYkwFLtnx7bysaNMdWAkRyXFM8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747825815; c=relaxed/simple; bh=t84jY8EW1u1kcNlMu1EhGlrTtqNqZWOz4Kds5scKVDY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ov7m0+KFojzd0ZsZdiOwc35Vw5YjwnKnv6CaUdlQaDz5znfCdPsIb1KHVPBH6dAA2kfxEkUXoc7dkvnW5JZL5Z/G+Mc5Ue9GtIeHPlyotEWifEs25yrdH6SOEiaRLsGl0Namae328yoL/TJMWY/34gZL4wg60kmMEo5W1WoelA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70C5725E4; Wed, 21 May 2025 04:09:59 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 294FC3F6A8; Wed, 21 May 2025 04:10:11 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: andrea.porta@suse.com, catalin.marinas@arm.com, jpoimboe@kernel.org, leitao@debian.org, linux-toolchains@vger.kernel.org, live-patching@vger.kernel.org, mark.rutland@arm.com, mbenes@suse.cz, pmladek@suse.com, song@kernel.org, will@kernel.org Subject: [PATCH 1/2] arm64: stacktrace: Check kretprobe_find_ret_addr() return value Date: Wed, 21 May 2025 12:09:59 +0100 Message-Id: <20250521111000.2237470-2-mark.rutland@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250521111000.2237470-1-mark.rutland@arm.com> References: <20250521111000.2237470-1-mark.rutland@arm.com> Precedence: bulk X-Mailing-List: linux-toolchains@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If kretprobe_find_ret_addr() fails to find the original return address, it returns 0. Check for this case so that a reliable stacktrace won't silently ignore it. Signed-off-by: Mark Rutland Cc: Andrea della Porta Cc: Breno Leitao Cc: Catalin Marinas Cc: Josh Poimboeuf Cc: Miroslav Benes Cc: Petr Mladek Cc: Song Liu Cc: Will Deacon --- arch/arm64/kernel/stacktrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 1d9d51d7627fd..f6494c0942144 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -152,6 +152,8 @@ kunwind_recover_return_address(struct kunwind_state *state) orig_pc = kretprobe_find_ret_addr(state->task, (void *)state->common.fp, &state->kr_cur); + if (!orig_pc) + return -EINVAL; state->common.pc = orig_pc; state->flags.kretprobe = 1; } -- 2.30.2