From: Florian Weimer <fw@deneb.enyo.de>
To: Mark Wielaard <mark@klomp.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
linux-toolchains@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, "Phillips\,
Kim" <kim.phillips@amd.com>, Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: Additional debug info to aid cacheline analysis
Date: Sun, 11 Oct 2020 14:28:09 +0200 [thread overview]
Message-ID: <874kn1x7za.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20201011122336.GC2666@wildebeest.org> (Mark Wielaard's message of "Sun, 11 Oct 2020 14:23:36 +0200")
* Mark Wielaard:
> On Sun, Oct 11, 2020 at 02:15:18PM +0200, Florian Weimer wrote:
>> * Mark Wielaard:
>>
>> > Yes, that would work. I don't know what the lowest supported GCC
>> > version is, but technically it was definitely fixed in 4.10.0, 4.8.4
>> > and 4.9.2. And various distros would probably have backported the
>> > fix. But checking for 5.0+ would certainly give you a good version.
>> >
>> > How about the attached?
>>
>> Would it be possible to test for the actual presence of the bug, using
>> -fcompare-debug?
>
> Yes, that was discussed in the original commit message, but it was decided
> that disabling it unconditionaly was easier. See commit 2062afb4f.
I think the short test case was not yet available at the time of the
Linux commit. But then it may not actually detect the bug in all
affected compilers.
Anyway, making this conditional on the GCC version is already a clear
improvement.
next prev parent reply other threads:[~2020-10-11 12:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 13:17 Additional debug info to aid cacheline analysis Peter Zijlstra
2020-10-06 19:00 ` Arnaldo Carvalho de Melo
2020-10-08 5:58 ` Stephane Eranian
2020-10-08 7:02 ` Peter Zijlstra
2020-10-08 9:32 ` Mark Wielaard
2020-10-08 21:23 ` Andi Kleen
2020-10-10 20:58 ` Mark Wielaard
2020-10-10 21:51 ` Mark Wielaard
[not found] ` <20201010220712.5352-1-mark@klomp.org>
2020-10-10 22:21 ` [PATCH] Only add -fno-var-tracking-assignments workaround for old GCC versions Ian Rogers
2020-10-12 18:59 ` Nick Desaulniers
2020-10-12 19:12 ` Mark Wielaard
2020-10-14 15:31 ` Sedat Dilek
2020-10-14 11:01 ` Mark Wielaard
2020-10-14 15:17 ` Andi Kleen
2020-10-17 12:01 ` [PATCH V2] " Mark Wielaard
2020-10-19 19:30 ` Nick Desaulniers
2020-10-20 15:27 ` Masahiro Yamada
2020-10-10 22:33 ` [PATCH] " Mark Wielaard
2020-10-11 11:04 ` Additional debug info to aid cacheline analysis Segher Boessenkool
2020-10-11 12:15 ` Florian Weimer
2020-10-11 12:23 ` Mark Wielaard
2020-10-11 12:28 ` Florian Weimer [this message]
2020-10-30 5:26 ` Namhyung Kim
2020-10-30 9:16 ` Mark Wielaard
2020-10-30 10:10 ` Peter Zijlstra
2020-11-02 8:27 ` Masami Hiramatsu
2020-11-03 4:22 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kn1x7za.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mark@klomp.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).