From: Thomas Gleixner <tglx@linutronix.de>
To: Vignesh Balasubramanian <vigbalas@amd.com>,
linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org
Cc: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
naveen.n.rao@linux.ibm.com, ebiederm@xmission.com,
keescook@chromium.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de,
binutils@sourceware.org, jhb@FreeBSD.org,
felix.willgerodt@intel.com,
Vignesh Balasubramanian <vigbalas@amd.com>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files
Date: Sat, 13 Jul 2024 12:42:14 +0200 [thread overview]
Message-ID: <87plrhshdl.ffs@tglx> (raw)
In-Reply-To: <20240712094630.29757-2-vigbalas@amd.com>
On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote:
> diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
> index 1fb83d477..cad37090b 100644
> --- a/arch/x86/include/asm/elf.h
> +++ b/arch/x86/include/asm/elf.h
> @@ -13,6 +13,15 @@
> #include <asm/auxvec.h>
> #include <asm/fsgsbase.h>
>
> +struct xfeat_component {
> + u32 type;
> + u32 size;
> + u32 offset;
> + u32 flags;
> +} __packed;
> +
> +_Static_assert(sizeof(struct xfeat_component)%4 == 0, "xfeat_component is not aligned");
This struct is only used in xstate.c and asm/elf.h is not a UAPI
header. So what's the point of declaring it in the header instead of
xtsate.c?
If this needs to provided for user space consumption, then it want's to
be in a UAPI header, no?
Thanks,
tglx
next prev parent reply other threads:[~2024-07-13 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 9:46 [PATCH v3 0/1] Add XSAVE layout description to Core files for debuggers to support varying XSAVE layouts Vignesh Balasubramanian
2024-07-12 9:46 ` [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files Vignesh Balasubramanian
2024-07-13 10:42 ` Thomas Gleixner [this message]
2024-07-17 9:32 ` Balasubrmanian, Vignesh
2024-07-17 17:16 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plrhshdl.ffs@tglx \
--to=tglx@linutronix.de \
--cc=aneesh.kumar@kernel.org \
--cc=binutils@sourceware.org \
--cc=bp@alien8.de \
--cc=bpetkov@amd.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ebiederm@xmission.com \
--cc=felix.willgerodt@intel.com \
--cc=jhb@FreeBSD.org \
--cc=jinisusan.george@amd.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matz@suse.de \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=vigbalas@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).