From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12371C00140 for ; Wed, 24 Aug 2022 16:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238717AbiHXQQv (ORCPT ); Wed, 24 Aug 2022 12:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237458AbiHXQQu (ORCPT ); Wed, 24 Aug 2022 12:16:50 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9113326F6; Wed, 24 Aug 2022 09:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kULtSLmXAg2mmU6izdJJrTMPsKQ/4zaIhDQaWWwzK3o=; b=bSCAwSIRCDDU3VeFWu5DIbeSkm umiEh7LIyj/bJoGk0OvRlrrD1yOzHRRZNXwUnzIR64kfonK293kfPZ+CcWM4sPAlInpI5qedl2emb UelxpwtyFgSaT7SiTugm6xMJaZwJZmUNspe0SCqQ1UucOhwSm5E79jREOnAEmLynj4+BvaN2ZImLr dPya6YujQolbZs2U0ATbu0flgEWVaxn+OFsRF+0NCrqEmJqkpcuIETKrzycB5+I2/yX71IqpxuBwT 3OVNOvn9JsCi6hpnlnzKPn6ZgEAtbOkHTLaAi9F47SreGec6tI2/28cNkAlqY7MhUgu6+8e4KnLKy KZAsKBTQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQt3V-005mck-5m; Wed, 24 Aug 2022 16:16:37 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 14379980BE2; Wed, 24 Aug 2022 18:16:35 +0200 (CEST) Date: Wed, 24 Aug 2022 18:16:34 +0200 From: Peter Zijlstra To: Borislav Petkov Cc: X86 ML , Michael Matz , linux-toolchains@vger.kernel.org, LKML , Josh Poimboeuf Subject: Re: [PATCH] x86/sev: Mark snp_abort() noreturn Message-ID: References: <20220824152420.20547-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Wed, Aug 24, 2022 at 05:48:56PM +0200, Borislav Petkov wrote: > On Wed, Aug 24, 2022 at 05:38:26PM +0200, Peter Zijlstra wrote: > > You'll probably also have to add it to the > > objtool/check.c:global_noreturn[] list, for the case where objtool fails > > to recognise it as noreturn. > > How come? > > Doesn't objtool see the attribute? If only there would be a trace of it left in the ELF file...