From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-toolchains@vger.kernel.org, Jordan Rome <jordalgo@meta.com>,
Sam James <sam@gentoo.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jens Remus <jremus@linux.ibm.com>,
Florian Weimer <fweimer@redhat.com>,
Andy Lutomirski <luto@kernel.org>, Weinan Liu <wnliu@google.com>,
Blake Jones <blakejones@google.com>,
Beau Belgrave <beaub@linux.microsoft.com>,
"Jose E. Marchesi" <jemarch@gnu.org>,
Alexander Aring <aahringo@redhat.com>
Subject: Re: [PATCH v6 5/5] perf: Support deferred user callchains for per CPU events
Date: Thu, 1 May 2025 13:20:55 -0700 [thread overview]
Message-ID: <aBPXpyd8HM6JrDPg@google.com> (raw)
In-Reply-To: <20250501013506.751321323@goodmis.org>
On Wed, Apr 30, 2025 at 09:32:07PM -0400, Steven Rostedt wrote:
> @@ -13100,13 +13269,20 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
> }
> }
>
> + /* Setup unwind deferring for per CPU events */
> + if (event->attr.defer_callchain && !task) {
> + err = perf_add_unwind_deferred(event);
> + if (err)
> + return ERR_PTR(err);
> + }
> +
> err = security_perf_event_alloc(event);
> if (err)
> return ERR_PTR(err);
It seems perf_remove_unwind_deferred() is not called from
__free_event() - with double underscores.
Thanks,
Namhyung
>
> if (event->attr.defer_callchain)
> init_task_work(&event->pending_unwind_work,
> - perf_event_callchain_deferred);
> + perf_event_deferred_task);
>
> /* symmetric to unaccount_event() in _free_event() */
> account_event(event);
> --
> 2.47.2
>
>
prev parent reply other threads:[~2025-05-01 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 1:32 [PATCH v6 0/5] perf: Deferred unwinding of user space stack traces for per CPU events Steven Rostedt
2025-05-01 1:32 ` [PATCH v6 1/5] unwind_user/deferred: Add deferred unwinding interface Steven Rostedt
2025-05-01 1:32 ` [PATCH v6 2/5] unwind_user/deferred: Make unwind deferral requests NMI-safe Steven Rostedt
2025-05-01 1:32 ` [PATCH v6 3/5] unwind deferred: Use bitmask to determine which callbacks to call Steven Rostedt
2025-05-01 1:32 ` [PATCH v6 4/5] unwind deferred: Use SRCU unwind_deferred_task_work() Steven Rostedt
2025-05-01 1:32 ` [PATCH v6 5/5] perf: Support deferred user callchains for per CPU events Steven Rostedt
2025-05-01 20:14 ` Namhyung Kim
2025-05-01 20:57 ` Steven Rostedt
2025-05-02 20:16 ` Namhyung Kim
2025-05-01 20:20 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBPXpyd8HM6JrDPg@google.com \
--to=namhyung@kernel.org \
--cc=aahringo@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=beaub@linux.microsoft.com \
--cc=blakejones@google.com \
--cc=broonie@kernel.org \
--cc=fweimer@redhat.com \
--cc=indu.bhagat@oracle.com \
--cc=irogers@google.com \
--cc=jemarch@gnu.org \
--cc=jolsa@kernel.org \
--cc=jordalgo@meta.com \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sam@gentoo.org \
--cc=wnliu@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).