From: David Laight <David.Laight@ACULAB.COM>
To: 'Segher Boessenkool' <segher@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Nick Desaulniers <ndesaulniers@google.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Bill Wendling <morbo@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "Nathan Chancellor" <nathan@kernel.org>,
Juergen Gross <jgross@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
LKML <linux-kernel@vger.kernel.org>,
linux-toolchains <linux-toolchains@vger.kernel.org>
Subject: RE: [PATCH v5] x86: use builtins to read eflags
Date: Fri, 18 Mar 2022 22:36:48 +0000 [thread overview]
Message-ID: <ad0d80fdfb404df6a98c68e759fca199@AcuMS.aculab.com> (raw)
In-Reply-To: <20220318220901.GS614@gate.crashing.org>
From: Segher Boessenkool
> Sent: 18 March 2022 22:09
...
> It generally is a very good idea to
> have a redzone though, without it you pay much more than necessary for
> frame setup and teardown in leaf functions (similar to some of what the
> misnamed "shrink-wrapping" optimisation does, but the two are mostly
> independent, the benefits add up).
Are there really leaf functions that need to spill data to stack
where the cost of setting up a stack frame is significant?
I'd have thought that was relatively rare.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-03-18 22:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220210223134.233757-1-morbo@google.com>
[not found] ` <20220301201903.4113977-1-morbo@google.com>
[not found] ` <CAGG=3QWh90r5C3gmTj9zxiJb-mwD=PGqGwZZTjAfyi1NCb1_9w@mail.gmail.com>
[not found] ` <AC3D873E-A28B-41F1-8BF4-2F6F37BCEEB4@zytor.com>
[not found] ` <CAGG=3QVu5QjQK8m2FWiYn-XQuVBjUGXcbznSbK22jVMB5GAutw@mail.gmail.com>
[not found] ` <F5296439-4CA3-4F31-BD91-5ED1510BC382@zytor.com>
2022-03-17 18:00 ` [PATCH v5] x86: use builtins to read eflags Nick Desaulniers
2022-03-17 18:52 ` Linus Torvalds
2022-03-17 19:45 ` Bill Wendling
2022-03-17 20:13 ` Linus Torvalds
2022-03-17 21:10 ` Bill Wendling
2022-03-17 21:21 ` Linus Torvalds
2022-03-17 21:45 ` Bill Wendling
2022-03-17 22:51 ` Linus Torvalds
2022-03-17 23:14 ` Linus Torvalds
2022-03-17 23:19 ` Segher Boessenkool
2022-03-17 23:31 ` Linus Torvalds
2022-03-18 0:05 ` Segher Boessenkool
2022-03-17 22:37 ` Segher Boessenkool
2022-03-17 20:13 ` Florian Weimer
2022-03-17 20:36 ` Linus Torvalds
2022-03-18 0:25 ` Segher Boessenkool
2022-03-18 1:21 ` Linus Torvalds
2022-03-18 1:50 ` Linus Torvalds
2022-03-17 21:05 ` Andrew Cooper
2022-03-17 21:39 ` Linus Torvalds
2022-03-18 17:59 ` Andy Lutomirski
2022-03-18 18:19 ` Linus Torvalds
2022-03-18 21:48 ` Andrew Cooper
2022-03-18 23:10 ` Linus Torvalds
2022-03-18 23:42 ` Segher Boessenkool
2022-03-19 1:13 ` Linus Torvalds
2022-03-19 23:15 ` Andy Lutomirski
2022-03-18 22:09 ` Segher Boessenkool
2022-03-18 22:33 ` H. Peter Anvin
2022-03-18 22:36 ` David Laight [this message]
2022-03-18 22:47 ` H. Peter Anvin
2022-03-18 22:43 ` David Laight
2022-03-18 23:03 ` H. Peter Anvin
2022-03-18 23:04 ` Segher Boessenkool
2022-03-18 23:52 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0d80fdfb404df6a98c68e759fca199@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).