From: David Laight <David.Laight@ACULAB.COM>
To: 'Peter Zijlstra' <peterz@infradead.org>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Bill Wendling <morbo@google.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"seanjc@google.com" <seanjc@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"mbenes@suse.cz" <mbenes@suse.cz>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>
Subject: RE: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage
Date: Wed, 10 Nov 2021 10:46:42 +0000 [thread overview]
Message-ID: <f6dbe42651e84278b44e44ed7d0ed74f@AcuMS.aculab.com> (raw)
In-Reply-To: <20211109210736.GV174703@worktop.programming.kicks-ass.net>
From: Peter Zijlstra
> Sent: 09 November 2021 21:08
...
>
> GCC does the same, but I wanted to have the exception stuff be in
> .text.cold, but alas it doesn't do that. I left the attribute because of
> it's descriptive value.
>
> > Unless the cold attribute is helping move
> > ("shrink-wrap"?) the basic block to a whole other section
> > (.text.cold.)?
>
> I was hoping it would do that, but it doesn't on gcc-11.
Wouldn't moving part of a function to .text.cold (or .text.unlikely)
generate the same problems with the stack backtrace code as the
.text.fixup section you are removing had??
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-11-10 10:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211105171023.989862879@infradead.org>
[not found] ` <20211105171821.654356149@infradead.org>
[not found] ` <20211108164711.mr2cqdcvedin2lvx@treble>
[not found] ` <YYlshkTmf5zdvf1Q@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdkFZ4PSN0GGmKMmoCrcp7_VVNjau_b0sNRm3MuqVi8yow@mail.gmail.com>
[not found] ` <YYov8SVHk/ZpFsUn@hirez.programming.kicks-ass.net>
2021-11-09 19:22 ` [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage Nick Desaulniers
2021-11-09 20:59 ` Bill Wendling
2021-11-09 21:21 ` Peter Zijlstra
2021-11-09 21:25 ` Nick Desaulniers
2021-11-09 22:11 ` Peter Zijlstra
2021-11-09 22:15 ` Nick Desaulniers
2021-11-09 21:07 ` Peter Zijlstra
2021-11-10 10:18 ` Peter Zijlstra
2021-11-10 10:46 ` David Laight [this message]
2021-11-10 11:09 ` Peter Zijlstra
2021-11-10 12:20 ` David Laight
2021-11-12 1:50 ` Josh Poimboeuf
2021-11-12 9:33 ` Peter Zijlstra
2021-11-13 5:35 ` Josh Poimboeuf
2021-11-15 12:36 ` Miroslav Benes
2021-11-15 13:01 ` Joe Lawrence
2021-11-15 23:40 ` Josh Poimboeuf
2021-11-16 7:25 ` Miroslav Benes
2021-11-15 12:59 ` Miroslav Benes
2021-11-16 21:27 ` Josh Poimboeuf
2021-11-18 7:15 ` Miroslav Benes
2021-11-22 17:46 ` Petr Mladek
2021-11-24 17:42 ` Josh Poimboeuf
2021-11-25 8:18 ` Petr Mladek
2021-11-10 12:14 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6dbe42651e84278b44e44ed7d0ed74f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=dvyukov@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).