From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA4CC43219 for ; Sat, 4 May 2019 08:27:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A614920652 for ; Sat, 4 May 2019 08:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n+OwnWiy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725826AbfEDI1v (ORCPT ); Sat, 4 May 2019 04:27:51 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40070 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbfEDI1v (ORCPT ); Sat, 4 May 2019 04:27:51 -0400 Received: by mail-wr1-f66.google.com with SMTP id h4so10645083wre.7 for ; Sat, 04 May 2019 01:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D2kQo9hRx9o7bEDD0UK11w3ULUGMCCDibaIvyvg+7C8=; b=n+OwnWiybU3PwXS9OBmymG/3ff7OOw1dIigZ3574ZL0v0DUhCRWiJ8CHS0xonhgtmE FKzpDkMkqbrujLqIruUEGheDb9BI7wfE+b0Gf8q5xwp6A4MMUnpSyzCr751jWdFIIA7e U0xVgfXQJlMagUwMso9YPj8AQuN0oUwDLOvpfBE6Fe7UKRHGp4wZ3Ezm/aDRbaaykZwG zOHx9bvureRnc3EqH9EfGRPgKlW6kMvDFWJ7Ul4jtsZl4QR/ZVjAxmJI7ewkXEWAU42q JdXVTpnK/zQ96S2Ef9ywxVIeD0QkxeKOfEyLX9OdfqOy2aW044QYq1nMcgetu/CSwDvZ k4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D2kQo9hRx9o7bEDD0UK11w3ULUGMCCDibaIvyvg+7C8=; b=ny107JBBZcmNbBafvZR2rSvSlVpTLEp2QH+PxNUQ8LDrWfU9TW3fLseFJqEAfBI145 bWfNh+Ec1aTyiY9U5p+lCrLFAfnovIB9ynefakvg/uipJtL69SusSn0U/1q+mZjfJ/Ff +y7GjllYXRGRXKtdiJBz9pdZMzn+vRod7dN+QQNQkkH4KV7L2FUm5hR+sLnruEoG43In z/S7qtTu84MvS7klrnevHM75hYioWkEbcD9LTPSIK7DVBoP7IaDAaHcbIvG0AOZkEqjD vdB/f/YESgvOUr1bMXo/DhYotqAG7KpZEazGlZt7qCVQP2Sj434sMZII86fiCKPfC0py DYOA== X-Gm-Message-State: APjAAAVYmLMnjIyvracNbI0drKKqWZeRSS+8vYPBE+uzFnAlxX4no8P5 0ctSr8ssrGg0h8AnkNZwpUg= X-Google-Smtp-Source: APXvYqxgRARM8VHFvGhqSI6o59PCencu6HjX6Ff3OXsgdo9HuNIzp97wnRorvW7/ojok4MjuI7bkcQ== X-Received: by 2002:adf:a202:: with SMTP id p2mr10362724wra.166.1556958469283; Sat, 04 May 2019 01:27:49 -0700 (PDT) Received: from [192.168.0.108] ([84.40.104.204]) by smtp.gmail.com with ESMTPSA id o8sm5875760wra.4.2019.05.04.01.27.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 May 2019 01:27:48 -0700 (PDT) Subject: Re: [PATCH v2 3/8] kernel-shark: Add logic for the plugins search path To: Steven Rostedt , Yordan Karadzhov Cc: linux-trace-devel@vger.kernel.org, troyengel@gmail.com, Slavomir Kaslev References: <20190502124009.32208-1-ykaradzhov@vmware.com> <20190502124009.32208-4-ykaradzhov@vmware.com> <20190503190557.6e36e59a@gandalf.local.home> From: "Yordan Karadzhov (VMware)" Message-ID: <00b42af8-c822-82ea-76bd-afe6fe277644@gmail.com> Date: Sat, 4 May 2019 11:27:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503190557.6e36e59a@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On 4.05.19 г. 2:05 ч., Steven Rostedt wrote: > On Thu, 2 May 2019 15:40:04 +0300 > Yordan Karadzhov wrote: > >> If the application has not been started from its installation location >> and the the directory >> >> app_file_path + "../../kernel-shark/lib" >> >> exists, all build-in plugins will be loaded from this directory. In any >> other case all build-in plugins will be loaded from >> >> _INSTALL_PREFIX/lib/kshark/plugins/ >> >> Suggested-by: Steven Rostedt (VMware) >> Reviewed-by: Slavomir Kaslev >> Signed-off-by: Yordan Karadzhov >> --- >> kernel-shark/src/KsUtils.cpp | 40 ++++++++++++++++++------- >> kernel-shark/src/KsUtils.hpp | 2 ++ >> kernel-shark/src/plugins/CMakeLists.txt | 2 +- >> 3 files changed, 32 insertions(+), 12 deletions(-) >> > > Hi Yordan, > > After applying this patch, kernelshark's behavior for loading trace.dat > changed. It no longer looks for the file in the current directory. If I > run: > > # trace-cmd record -e sched_switch sleep 1 > # kernelshark > > It loads without loading the produced trace.dat. > > If I run: > > # kernelshark trace.dat > > I get an error message stating: > > "Unable to find file trace.dat" I see the problem. Have you pushed this patch already? I can send you a corrected version of the patch or a separate patch with the fix. Thanks! Yordan > > -- Steve >