From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] kernel-shark: Initialize the data-related fields of the model
Date: Wed, 17 Jul 2019 16:38:47 +0300 [thread overview]
Message-ID: <00e8b2e5-2112-0681-7cbb-a3919ddd63c8@gmail.com> (raw)
In-Reply-To: <20190717092818.34329697@gandalf.local.home>
On 17.07.19 г. 16:28 ч., Steven Rostedt wrote:
> On Wed, 17 Jul 2019 15:42:31 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
>>> Are we just trying to set all fields of histo to NULL or zero? If so,
>>> why not just do:
>>>
>>> memset(histo, 0, sizeof(*histo));
>>>
>>> ?
>>>
>>> This will make sure ksmodel_init() zeros all of histo when/if we add new
>>> fields.
>>>
>>
>> Yes, this will do a better job.
>
> Care to send a v2 patch?
Just make the change and apply, if this is OK with you.
Thanks a lot!
Yordan
>
> Thanks Yordan!
>
> -- Steve
>
next prev parent reply other threads:[~2019-07-17 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 8:53 [PATCH 0/2] Fixes for KS 1.0 Yordan Karadzhov (VMware)
2019-07-17 8:53 ` [PATCH 1/2] kernel-shark: Initialize the data-related fields of the model Yordan Karadzhov (VMware)
2019-07-17 12:37 ` Steven Rostedt
2019-07-17 12:42 ` Yordan Karadzhov (VMware)
2019-07-17 13:28 ` Steven Rostedt
2019-07-17 13:38 ` Yordan Karadzhov (VMware) [this message]
2019-07-17 19:26 ` Steven Rostedt
2019-07-17 19:27 ` Steven Rostedt
2019-07-18 6:36 ` Yordan Karadzhov (VMware)
2019-07-17 8:53 ` [PATCH 2/2] kernel-shark: Always check if data is loaded before changing the graphs Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e8b2e5-2112-0681-7cbb-a3919ddd63c8@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).