From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>, linux-trace-devel@vger.kernel.org
Cc: Josef Bacik <jbacik@fb.com>, Darren Hart <dvhart@infradead.org>,
troyengel@gmail.com
Subject: Re: [PATCH 3/3] trace-cmd: Use PyLong_AsLong() for Python 3
Date: Fri, 26 Jul 2019 09:31:57 +0200 [thread overview]
Message-ID: <076f6cad8adf6fd8eec78dfe7c8a76ed7d5914ae.camel@sipsolutions.net> (raw)
In-Reply-To: <20190719225030.507227790@goodmis.org>
On Fri, 2019-07-19 at 18:46 -0400, Steven Rostedt wrote:
> +#if PY_MAJOR_VERSION >= 3
[...]
> +#define PY_INT_AS_LONG PyLong_AsLong
> #else
[...]
> +#define PY_INT_AS_LONG PyInt_AS_LONG
> +#endif
I probably would've gone for only having a single
#define PyLong_AsLong PyInt_AS_LONG
in the python2 case, but doesn't really matter.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2019-07-26 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 22:46 [PATCH 0/3] trace-cmd: Update python plugin for Python 3 Steven Rostedt
2019-07-19 22:46 ` [PATCH 1/3] trace-cmd: Replace PySting_FromString() with PyUnicode_FromString() Steven Rostedt
2019-07-26 7:29 ` Johannes Berg
2019-07-19 22:46 ` [PATCH 2/3] trace-cmd: Use PyMemoryView_FromMemory() for Python 3 Steven Rostedt
2019-07-26 7:30 ` Johannes Berg
2019-07-19 22:46 ` [PATCH 3/3] trace-cmd: Use PyLong_AsLong() " Steven Rostedt
2019-07-26 7:31 ` Johannes Berg [this message]
2019-07-26 15:18 ` Steven Rostedt
2019-07-26 15:22 ` Johannes Berg
2019-07-26 15:30 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076f6cad8adf6fd8eec78dfe7c8a76ed7d5914ae.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dvhart@infradead.org \
--cc=jbacik@fb.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=troyengel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).