From: Victor Cora Colombo <victorcora98@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2] trace-cmd: Add dependencies to BUILDING section in README
Date: Thu, 19 Aug 2021 21:25:53 -0300 [thread overview]
Message-ID: <08e62ffe-c173-8c37-229f-39cf0977623c@gmail.com> (raw)
In-Reply-To: <20210819154233.3d4a75aa@oasis.local.home>
On 8/19/21 4:42 PM, Steven Rostedt wrote:
> On Fri, 13 Aug 2021 16:25:16 -0300
> victorcora98@gmail.com wrote:
>
>> From: Victor Cora Colombo <victorcora98@gmail.com>
>
> I finally got some time to look at this.
No problem!
>
>>
>> KernelShark has instructions in its README on how to get necessary
>> dependencies to build it. trace-cmd could follow this example and
>> also add more information on how to build it.
>>
>> This patch adds instructions to README on how to get necessary libraries
>> and dependencies to build trace-cmd.
>>
>> Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
>> ---
>> README | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/README b/README
>> index 1153152..094fce1 100644
>> --- a/README
>> +++ b/README
>> @@ -24,6 +24,23 @@ Lesser General Public License 2.1 (See COPYING.LIB).
>>
>> BUILDING:
>>
>> +In order to install build dependencies on Ubuntu do the following:
>> + sudo apt-get install build-essential git pkg-config -y
>> +
>> +In order to install build dependencies on Fedora, as root do the following:
>> + dnf install gcc make git pkg-config -y
>
> I would actually add above libtracefs-devel and libtraceevent-devel for
> fedora, and possibly libtracefs-dev and libtraceevent-dev for ubuntu /
> debian. Oh, I would say that too, as I don't use Ubuntu thus, state "on
> Debian / Ubuntu do the following".
>
>
>> +
>> +To install required dependencies:
>
> Then you can say here.
>
> In case the distribution does not have the required libtracefs and
> libtraceevent libraries, install them manually:
>
> Or something to that nature.
>
> -- Steve
That is a great idea, I'll take a look at it.
Thanks again!
-- Victor
>
>
>> + git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
>> + cd libtraceevent
>> + make
>> + sudo make install
>> +
>> + git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
>> + cd libtracefs
>> + make
>> + sudo make install
>> +
>> To make trace-cmd
>> make
>>
>
prev parent reply other threads:[~2021-08-20 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 19:25 [PATCH v2] trace-cmd: Add dependencies to BUILDING section in README victorcora98
2021-08-19 19:42 ` Steven Rostedt
2021-08-20 0:25 ` Victor Cora Colombo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e62ffe-c173-8c37-229f-39cf0977623c@gmail.com \
--to=victorcora98@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).