From: Slavomir Kaslev <kaslevs@vmware.com>
To: "rostedt@goodmis.org" <rostedt@goodmis.org>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd: Add trace-cmd report --version to extract version info
Date: Tue, 11 Jun 2019 12:40:38 +0000 [thread overview]
Message-ID: <0fd41ca481c3154c915e70ded50592314ae86cbb.camel@vmware.com> (raw)
In-Reply-To: <20190610212706.2505bffe@oasis.local.home>
On Mon, 2019-06-10 at 21:27 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> Now that the trace.dat file can save the version of the executable
> that was
> used to create it, save that information. This will be useful if a
> user has
> a problem with a trace.dat file. It can let the developers know what
> version
> was used to create it. We need a way to extract this information.
> Adding a
> new "--version" to trace-cmd report will display the saved version in
> the
> trace.dat file if it exists.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
Looks great.
Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
Cheers!
-- Slavi
prev parent reply other threads:[~2019-06-11 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 12:14 [PATCH] trace-cmd: Append metadata about trace-cmd's version when recording Slavomir Kaslev
2019-06-04 12:24 ` Steven Rostedt
2019-06-04 12:48 ` Slavomir Kaslev
2019-06-11 1:27 ` [PATCH] trace-cmd: Add trace-cmd report --version to extract version info Steven Rostedt
2019-06-11 12:40 ` Slavomir Kaslev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd41ca481c3154c915e70ded50592314ae86cbb.camel@vmware.com \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).